Commitff2e3ce

committed

gh-117151: IO performance improvement, increase io.DEFAULT_BUFFER_SIZE to 128k, fix open() to use max(st_blksize, io.DEFAULT_BUFFER_SIZE)

1 parent42351c3 commitff2e3ceCopy full SHA for ff2e3ce

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@`
`23`	`23`	`valid_seek_flags.add(os.SEEK_HOLE)`
`24`	`24`	`valid_seek_flags.add(os.SEEK_DATA)`
`25`	`25`
`26`		`-# open() uses st_blksize whenever we can`
`27`		`-DEFAULT_BUFFER_SIZE=8*1024# bytes`
	`26`	`+# open() usesmax(st_blksize, io.DEFAULT_BUFFER_SIZE) when st_blksize is available`
	`27`	`+DEFAULT_BUFFER_SIZE=128*1024# bytes`
`28`	`28`
`29`	`29`	`# NOTE: Base classes defined here are registered with the "official" ABCs`
`30`	`30`	`# defined in io.py. We don't use real inheritance though, because we don't want`
`@@ -249,7 +249,7 @@ def open(file, mode="r", buffering=-1, encoding=None, errors=None,`
`249`	`249`	`pass`
`250`	`250`	`else:`
`251`	`251`	`ifbs>1:`
`252`		`-buffering=bs`
	`252`	`+buffering=max(bs,DEFAULT_BUFFER_SIZE)`
`253`	`253`	`ifbuffering<0:`
`254`	`254`	`raiseValueError("invalid buffering size")`
`255`	`255`	`ifbuffering==0:`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+increase io.DEFAULT_BUFFER_SIZE from 4k/8k to 128k. fix open on Linux to use`
	`2`	`+max(io.DEFAULT_BUFFER_SIZE, device block size) rather than the device block`
	`3`	`+size. improve I/O performance by 3 to 5 times. patch by Romain Morotti.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ extern Py_ssize_t _PyIO_find_line_ending(`
`78`	`78`	`*/`
`79`	`79`	`externint_PyIO_trap_eintr(void);`
`80`	`80`
`81`		`-#defineDEFAULT_BUFFER_SIZE (8 * 1024)/* bytes */`
	`81`	`+#defineDEFAULT_BUFFER_SIZE (128 * 1024)/* bytes */`
`82`	`82`
`83`	`83`	`/*`
`84`	`84`	`* Offset type for positioning.`

Comments

(0)