Commitfda3291

miss-islington

and

hoodmane

authored

[3.13] DOCS: Suggest always calling exec with a globals argument and no locals argument (GH-119235) (#119239)

DOCS: Suggest always calling exec with a globals argument and no locals argument (GH-119235)Many users think they want a locals argument for various reasons but they do notunderstand that it makes code be treated as a class definition. They do not wanttheir code treated as a class definition and get surprised. The reason notto pass locals specifically is that the following code raises a `NameError`:```pyexec("""def f(): print("hi")f()def g(): f()g()""", {}, {})```The reason not to leave out globals is as follows:```pydef t(): exec("""def f(): print("hi")f()def g(): f()g() """)```(cherry picked from commit7e1a130)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>

1 parenta6b873f commitfda3291Copy full SHA for fda3291

File tree

1 file changed

-3

lines changed

Doc/library
- functions.rst

1 file changed

-3

lines changed

`‎Doc/library/functions.rst‎`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -608,9 +608,13 @@ are always available. They are listed here in alphabetical order.`
`608`	`608`	`will be used for both the global and the local variables. If globals and`
`609`	`609`	`locals are given, they are used for the global and local variables,`
`610`	`610`	`respectively. If provided, locals can be any mapping object. Remember`
`611`		`- that at the module level, globals and locals are the same dictionary. If exec`
`612`		`- gets two separate objects as globals and locals, the code will be`
`613`		`- executed as if it were embedded in a class definition.`
	`611`	`+ that at the module level, globals and locals are the same dictionary.`
	`612`	`+`
	`613`	`+ ..note::`
	`614`	`+`
	`615`	`+ Most users should just pass a globals argument and never locals.`
	`616`	`+ If exec gets two separate objects as globals and locals, the code`
	`617`	`+ will be executed as if it were embedded in a class definition.`
`614`	`618`
`615`	`619`	`If the globals dictionary does not contain a value for the key`
`616`	`620`	``__builtins__``, a reference to the dictionary of the built-in module

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitfda3291

File tree

1 file changed

1 file changed

`‎Doc/library/functions.rst‎`

0 commit comments