Commitee46cb6

and

authored

gh-105927: PyWeakref_GetRef() returns 1 on success (#106561)

PyWeakref_GetRef() now returns 1 on success, and return 0 if thereference is dead.Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

1 parent1e12c8c commitee46cb6Copy full SHA for ee46cb6

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,9 +55,11 @@ as much as it can.`
`55`	`55`
`56`	`56`	Get a:term:`strong reference` to the referenced object from a weak
`57`	`57`	`reference, ref, into \pobj*.`
`58`		`- Return 0 on success. Raise an exception and return -1 on error.`
`59`	`58`
`60`		- If the referent is no longer live, set \pobj* to ``NULL`` and return 0.
	`59`	+ * On success, set \pobj* to a new:term:`strong reference` to the
	`60`	`+ referenced object and return 1.`
	`61`	+ * If the reference is dead, set \pobj* to ``NULL`` and return 0.
	`62`	`+ * On error, raise an exception and return -1.`
`61`	`63`
`62`	`64`	`..versionadded::3.13`
`63`	`65`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3376,7 +3376,7 @@ test_weakref_capi(PyObject Py_UNUSED(module), PyObject Py_UNUSED(args))`
`3376`	`3376`
`3377`	`3377`	`// test PyWeakref_GetRef(), reference is alive`
`3378`	`3378`	`PyObject*ref=Py_True;// marker to check that value was set`
`3379`		`-assert(PyWeakref_GetRef(weakref,&ref)==0);`
	`3379`	`+assert(PyWeakref_GetRef(weakref,&ref)==1);`
`3380`	`3380`	`assert(ref==obj);`
`3381`	`3381`	`assert(Py_REFCNT(obj)== (refcnt+1));`
`3382`	`3382`	`Py_DECREF(ref);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -913,7 +913,7 @@ PyWeakref_GetRef(PyObject ref, PyObject *pobj)`
`913`	`913`	`return-1;`
`914`	`914`	`}`
`915`	`915`	`*pobj=_PyWeakref_GET_REF(ref);`
`916`		`-return0;`
	`916`	`+return(*pobj!=NULL);`
`917`	`917`	`}`
`918`	`918`
`919`	`919`

Comments

(0)