NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

Commitea1803e

authored

gh-88118: Fix some test_multiprocessing flakiness. (#116434)

Fix some test_multiprocessing flakiness.Potentially introduced by#25845not joining that thread likely leads to recently observed "environmentchanged" logically passing but overall failing tests seen on somebuildbots similar to:```1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes```

1 parentc62144a commitea1803eCopy full SHA for ea1803e

File tree

1 file changed

+10

-5

lines changed

Lib/test
- _test_multiprocessing.py

1 file changed

+10

-5

lines changed

`‎Lib/test/_test_multiprocessing.py`

Lines changed: 10 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -3513,15 +3513,20 @@ def run(addr, authkey):`
`3513`	`3513`	`client=self.connection.Client(addr,authkey=authkey)`
`3514`	`3514`	`client.send(1729)`
`3515`	`3515`
`3516`		`-key=b""`
	`3516`	`+key=b''`
`3517`	`3517`
`3518`	`3518`	`withself.connection.Listener(authkey=key)aslistener:`
`3519`		`-threading.Thread(target=run,args=(listener.address,key)).start()`
`3520`		`-withlistener.accept()asd:`
`3521`		`-self.assertEqual(d.recv(),1729)`
	`3519`	`+thread=threading.Thread(target=run,args=(listener.address,key))`
	`3520`	`+thread.start()`
	`3521`	`+try:`
	`3522`	`+withlistener.accept()asd:`
	`3523`	`+self.assertEqual(d.recv(),1729)`
	`3524`	`+finally:`
	`3525`	`+thread.join()`
`3522`	`3526`
`3523`	`3527`	`ifself.TYPE=='processes':`
`3524`		`-self.assertRaises(OSError,listener.accept)`
	`3528`	`+withself.assertRaises(OSError):`
	`3529`	`+listener.accept()`
`3525`	`3530`
`3526`	`3531`	`@unittest.skipUnless(util.abstract_sockets_supported,`
`3527`	`3532`	`"test needs abstract socket support")`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitea1803e

File tree

1 file changed

1 file changed

`‎Lib/test/_test_multiprocessing.py`

0 commit comments