Commite860e52

authored

gh-90467: StreamReaderProtocol - add strong reference to created task (#96323)

1 parent6fbd889 commite860e52Copy full SHA for e860e52

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -205,6 +205,7 @@ def __init__(self, stream_reader, client_connected_cb=None, loop=None):`
`205`	`205`	`self._strong_reader=stream_reader`
`206`	`206`	`self._reject_connection=False`
`207`	`207`	`self._stream_writer=None`
	`208`	`+self._task=None`
`208`	`209`	`self._transport=None`
`209`	`210`	`self._client_connected_cb=client_connected_cb`
`210`	`211`	`self._over_ssl=False`
`@@ -247,7 +248,7 @@ def connection_made(self, transport):`
`247`	`248`	`res=self._client_connected_cb(reader,`
`248`	`249`	`self._stream_writer)`
`249`	`250`	`ifcoroutines.iscoroutine(res):`
`250`		`-self._loop.create_task(res)`
	`251`	`+self._task=self._loop.create_task(res)`
`251`	`252`	`self._strong_reader=None`
`252`	`253`
`253`	`254`	`defconnection_lost(self,exc):`
`@@ -265,6 +266,7 @@ def connection_lost(self, exc):`
`265`	`266`	`super().connection_lost(exc)`
`266`	`267`	`self._stream_reader_wr=None`
`267`	`268`	`self._stream_writer=None`
	`269`	`+self._task=None`
`268`	`270`	`self._transport=None`
`269`	`271`
`270`	`272`	`defdata_received(self,data):`

Lines changed: 2 additions & 0 deletions

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fix:class:`asyncio.streams.StreamReaderProtocol` to keep a strong reference
	`2`	`+to the created task, so that it's not garbage collected`

Comments

(0)