Commite7c5f60

authored

gh-130167: Improve the error case fortextwrap.dedent (#132666)

1 parentc821b71 commite7c5f60Copy full SHA for e7c5f60

File tree

+13

-5

lines changed

+13

-5

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -765,6 +765,13 @@ def test_subsequent_indent(self):`
`765`	`765`	`# of IndentTestCase!`
`766`	`766`	`classDedentTestCase(unittest.TestCase):`
`767`	`767`
	`768`	`+deftest_type_error(self):`
	`769`	`+withself.assertRaisesRegex(TypeError,"expected str object, not"):`
	`770`	`+dedent(0)`
	`771`	`+`
	`772`	`+withself.assertRaisesRegex(TypeError,"expected str object, not"):`
	`773`	`+dedent(b'')`
	`774`	`+`
`768`	`775`	`defassertUnchanged(self,text):`
`769`	`776`	`"""assert that dedent() has no effect on 'text'"""`
`770`	`777`	`self.assertEqual(text,dedent(text))`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -426,10 +426,11 @@ def dedent(text):`
`426`	`426`
`427`	`427`	`Entirely blank lines are normalized to a newline character.`
`428`	`428`	`"""`
`429`		`-ifnottext:`
`430`		`-returntext`
`431`		`-`
`432`		`-lines=text.split('\n')`
	`429`	`+try:`
	`430`	`+lines=text.split('\n')`
	`431`	`+except (AttributeError,TypeError):`
	`432`	`+msg=f'expected str object, not{type(text).__qualname__!r}'`
	`433`	`+raiseTypeError(msg)fromNone`
`433`	`434`
`434`	`435`	# Get length of leading whitespace, inspired by ``os.path.commonprefix()``.
`435`	`436`	`non_blank_lines= [lforlinlinesiflandnotl.isspace()]`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -288,7 +288,7 @@ Improve the import time of the :mod:`ast` module by extracting the
`288`	`288`	`.. nonce: 8M-HVz`
`289`	`289`	`.. section: Library`
`290`	`290`
`291`		-Improved performance of:func:`textwrap.dedent` by an average of ~1.3x.
	`291`	+Improved performance of:func:`textwrap.indent` by an average of ~1.3x.
`292`	`292`	`Patch by Adam Turner.`
`293`	`293`
`294`	`294`	`..`

Comments

(0)