Commite64395e

authored

gh-134262: Fix off by one errors in download retry functions (GH-134867)

1 parente9d845b commite64395eCopy full SHA for e64395e

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`defretrieve_with_retries(download_location,output_path,reporthook,`
`13`	`13`	`max_retries=7):`
`14`	`14`	`"""Download a file with exponential backoff retry and save to disk."""`
`15`		`-forattemptinrange(max_retries):`
	`15`	`+forattemptinrange(max_retries+1):`
`16`	`16`	`try:`
`17`	`17`	`resp=urlretrieve(`
`18`	`18`	`download_location,`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ def download_with_retries(download_location: str,`
`169`	`169`	`base_delay:float=2.25,`
`170`	`170`	`max_jitter:float=1.0)->typing.Any:`
`171`	`171`	`"""Download a file with exponential backoff retry."""`
`172`		`-forattemptinrange(max_retries):`
	`172`	`+forattemptinrange(max_retries+1):`
`173`	`173`	`try:`
`174`	`174`	`resp=urllib.request.urlopen(download_location)`
`175`	`175`	`excepturllib.error.URLErrorasex:`

Comments

(0)