Commitde7a1ce

authored and

Christian Klein

committed

Respect mock spec when checking for unsafe prefixes

1 parenta286caa commitde7a1ceCopy full SHA for de7a1ce

File tree

+10

-1

lines changed

+10

-1

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1652,6 +1652,15 @@ def test_mock_unsafe(self):`
`1652`	`1652`	`m.aseert_foo_call()`
`1653`	`1653`	`m.assrt_foo_call()`
`1654`	`1654`
	`1655`	`+# gh-100739`
	`1656`	`+deftest_mock_safe_with_spec(self):`
	`1657`	`+classFoo(object):`
	`1658`	`+defassert_bar(self):`
	`1659`	`+pass`
	`1660`	`+`
	`1661`	`+m=Mock(spec=Foo)`
	`1662`	`+m.assert_bar()`
	`1663`	`+`
`1655`	`1664`	`#Issue21262`
`1656`	`1665`	`deftest_assert_not_called(self):`
`1657`	`1666`	`m=Mock()`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -652,7 +652,7 @@ def __getattr__(self, name):`
`652`	`652`	`raiseAttributeError("Mock object has no attribute %r"%name)`
`653`	`653`	`elif_is_magic(name):`
`654`	`654`	`raiseAttributeError(name)`
`655`		`-ifnotself._mock_unsafe:`
	`655`	`+ifnotself._mock_unsafeand (notself._mock_methodsornamenotinself._mock_methods):`
`656`	`656`	`ifname.startswith(('assert','assret','asert','aseert','assrt')):`
`657`	`657`	`raiseAttributeError(`
`658`	`658`	`f"{name!r} is not a valid assertion. Use a spec "`

Comments

(0)