Commitdb098a4

authored

gh-133146: Add the old publicget_value method to documentation and refactor code. (GH-133301)

also uses it within the internals in a few places.

1 parentf2ca158 commitdb098a4Copy full SHA for db098a4

File tree

+20

-5

lines changed

+20

-5

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1577,12 +1577,22 @@ object -- see :ref:`multiprocessing-managers`.
`1577`	`1577`	A solitary difference from its close analog exists: its ``acquire`` method's
`1578`	`1578`	first argument is named block, as is consistent with:meth:`Lock.acquire`.
`1579`	`1579`
	`1580`	`+`
	`1581`	`+ ..method::get_value()`
	`1582`	`+`
	`1583`	`+ Return the current value of semaphore.`
	`1584`	`+`
	`1585`	+ Note that this may raise:exc:`NotImplementedError` on platforms like
	`1586`	+ macOS where ``sem_getvalue()`` is not implemented.
	`1587`	`+`
	`1588`	`+`
`1580`	`1589`	`..method::locked()`
`1581`	`1590`
`1582`	`1591`	`Return a boolean indicating whether this object is locked right now.`
`1583`	`1592`
`1584`	`1593`	`..versionadded::3.14`
`1585`	`1594`
	`1595`	`+`
`1586`	`1596`	`..note::`
`1587`	`1597`
`1588`	`1598`	On macOS, ``sem_timedwait`` is unsupported, so calling ``acquire()`` with

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ def get(self, block=True, timeout=None):`
`121`	`121`
`122`	`122`	`defqsize(self):`
`123`	`123`	`# Raises NotImplementedError on Mac OSX because of broken sem_getvalue()`
`124`		`-returnself._maxsize-self._sem._semlock._get_value()`
	`124`	`+returnself._maxsize-self._sem.get_value()`
`125`	`125`
`126`	`126`	`defempty(self):`
`127`	`127`	`returnnotself._poll()`

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -135,11 +135,16 @@ def __init__(self, value=1, *, ctx):`
`135`	`135`	`SemLock.__init__(self,SEMAPHORE,value,SEM_VALUE_MAX,ctx=ctx)`
`136`	`136`
`137`	`137`	`defget_value(self):`
	`138`	`+'''Returns current value of Semaphore.`
	`139`	`+`
	`140`	`+ Raises NotImplementedError on Mac OSX`
	`141`	`+ because of broken sem_getvalue().`
	`142`	`+ '''`
`138`	`143`	`returnself._semlock._get_value()`
`139`	`144`
`140`	`145`	`def__repr__(self):`
`141`	`146`	`try:`
`142`		`-value=self._semlock._get_value()`
	`147`	`+value=self.get_value()`
`143`	`148`	`exceptException:`
`144`	`149`	`value='unknown'`
`145`	`150`	`return'<%s(value=%s)>'% (self.__class__.__name__,value)`
`@@ -155,7 +160,7 @@ def __init__(self, value=1, *, ctx):`
`155`	`160`
`156`	`161`	`def__repr__(self):`
`157`	`162`	`try:`
`158`		`-value=self._semlock._get_value()`
	`163`	`+value=self.get_value()`
`159`	`164`	`exceptException:`
`160`	`165`	`value='unknown'`
`161`	`166`	`return'<%s(value=%s, maxvalue=%s)>'% \`
`@@ -247,8 +252,8 @@ def _make_methods(self):`
`247`	`252`
`248`	`253`	`def__repr__(self):`
`249`	`254`	`try:`
`250`		`-num_waiters= (self._sleeping_count._semlock._get_value()-`
`251`		`-self._woken_count._semlock._get_value())`
	`255`	`+num_waiters= (self._sleeping_count.get_value()-`
	`256`	`+self._woken_count.get_value())`
`252`	`257`	`exceptException:`
`253`	`258`	`num_waiters='unknown'`
`254`	`259`	`return'<%s(%s, %s)>'% (self.__class__.__name__,self._lock,num_waiters)`

Comments

(0)