NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

Commitdb03cb9

authored

[3.11]gh-107237: Fix test_udp_reconnection() of test_logging (#107238) (#107245)

gh-107237: Fix test_udp_reconnection() of test_logging (#107238)test_logging: Fix test_udp_reconnection() by increasing the timeoutfrom 100 ms to 5 minutes (LONG_TIMEOUT).Replace also blocking wait() with wait(LONG_TIMEOUT) intest_output() to prevent the test to hang.(cherry picked from commited08238)

1 parent1bc1609 commitdb03cb9Copy full SHA for db03cb9

File tree

2 files changed

-4

lines changed

Lib/test
- test_logging.py
Misc/NEWS.d/next/Tests
- 2023-07-25-14-36-33.gh-issue-107237.y1pY79.rst

2 files changed

-4

lines changed

`‎Lib/test/test_logging.py‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1981,25 +1981,25 @@ def test_output(self):`
`1981`	`1981`	`# The log message sent to the SysLogHandler is properly received.`
`1982`	`1982`	`logger=logging.getLogger("slh")`
`1983`	`1983`	`logger.error("sp\xe4m")`
`1984`		`-self.handled.wait()`
	`1984`	`+self.handled.wait(support.LONG_TIMEOUT)`
`1985`	`1985`	`self.assertEqual(self.log_output,b'<11>sp\xc3\xa4m\x00')`
`1986`	`1986`	`self.handled.clear()`
`1987`	`1987`	`self.sl_hdlr.append_nul=False`
`1988`	`1988`	`logger.error("sp\xe4m")`
`1989`		`-self.handled.wait()`
	`1989`	`+self.handled.wait(support.LONG_TIMEOUT)`
`1990`	`1990`	`self.assertEqual(self.log_output,b'<11>sp\xc3\xa4m')`
`1991`	`1991`	`self.handled.clear()`
`1992`	`1992`	`self.sl_hdlr.ident="h\xe4m-"`
`1993`	`1993`	`logger.error("sp\xe4m")`
`1994`		`-self.handled.wait()`
	`1994`	`+self.handled.wait(support.LONG_TIMEOUT)`
`1995`	`1995`	`self.assertEqual(self.log_output,b'<11>h\xc3\xa4m-sp\xc3\xa4m')`
`1996`	`1996`
`1997`	`1997`	`deftest_udp_reconnection(self):`
`1998`	`1998`	`logger=logging.getLogger("slh")`
`1999`	`1999`	`self.sl_hdlr.close()`
`2000`	`2000`	`self.handled.clear()`
`2001`	`2001`	`logger.error("sp\xe4m")`
`2002`		`-self.handled.wait(0.1)`
	`2002`	`+self.handled.wait(support.LONG_TIMEOUT)`
`2003`	`2003`	`self.assertEqual(self.log_output,b'<11>sp\xc3\xa4m\x00')`
`2004`	`2004`
`2005`	`2005`	`@unittest.skipUnless(hasattr(socket,"AF_UNIX"),"Unix sockets required")`

`‎Misc/NEWS.d/next/Tests/2023-07-25-14-36-33.gh-issue-107237.y1pY79.rst‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+``test_logging``: Fix ``test_udp_reconnection()`` by increasing the timeout
	`2`	`+from 100 ms to 5 minutes (LONG_TIMEOUT). Patch by Victor Stinner.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitdb03cb9

File tree

2 files changed

2 files changed

`‎Lib/test/test_logging.py‎`

`‎Misc/NEWS.d/next/Tests/2023-07-25-14-36-33.gh-issue-107237.y1pY79.rst‎`

0 commit comments