Commitd7eea0f

and

authored

gh-96175: add missing self._localName assignment inxml.dom.minidom.Attr (GH-96176)

X-Ref:https://github.com/python/typeshed/pull/8590GH-discussion_r951473977Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit58f6953)Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>

1 parent0aed1e7 commitd7eea0fCopy full SHA for d7eea0f

File tree

+18

-1

lines changed

+18

-1

lines changed

Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`importpyexpat`
`10`	`10`	`importxml.dom.minidom`
`11`	`11`
`12`		`-fromxml.dom.minidomimportparse,Node,Document,parseString`
	`12`	`+fromxml.dom.minidomimportparse,Attr,Node,Document,parseString`
`13`	`13`	`fromxml.dom.minidomimportgetDOMImplementation`
`14`	`14`	`fromxml.parsers.expatimportExpatError`
`15`	`15`
`@@ -77,6 +77,20 @@ def testParseFromTextFile(self):`
`77`	`77`	`dom.unlink()`
`78`	`78`	`self.confirm(isinstance(dom,Document))`
`79`	`79`
	`80`	`+deftestAttrModeSetsParamsAsAttrs(self):`
	`81`	`+attr=Attr("qName","namespaceURI","localName","prefix")`
	`82`	`+self.assertEqual(attr.name,"qName")`
	`83`	`+self.assertEqual(attr.namespaceURI,"namespaceURI")`
	`84`	`+self.assertEqual(attr.prefix,"prefix")`
	`85`	`+self.assertEqual(attr.localName,"localName")`
	`86`	`+`
	`87`	`+deftestAttrModeSetsNonOptionalAttrs(self):`
	`88`	`+attr=Attr("qName","namespaceURI",None,"prefix")`
	`89`	`+self.assertEqual(attr.name,"qName")`
	`90`	`+self.assertEqual(attr.namespaceURI,"namespaceURI")`
	`91`	`+self.assertEqual(attr.prefix,"prefix")`
	`92`	`+self.assertEqual(attr.localName,attr.name)`
	`93`	`+`
`80`	`94`	`deftestGetElementsByTagName(self):`
`81`	`95`	`dom=parse(tstfile)`
`82`	`96`	`self.confirm(dom.getElementsByTagName("LI")== \`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -358,6 +358,8 @@ def __init__(self, qName, namespaceURI=EMPTY_NAMESPACE, localName=None,`
`358`	`358`	`self._name=qName`
`359`	`359`	`self.namespaceURI=namespaceURI`
`360`	`360`	`self._prefix=prefix`
	`361`	`+iflocalNameisnotNone:`
	`362`	`+self._localName=localName`
`361`	`363`	`self.childNodes=NodeList()`
`362`	`364`
`363`	`365`	`# Add the single child node that represents the value of the attr`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix unused ``localName`` parameter in the ``Attr`` class in:mod:`xml.dom.minidom`.

Comments

(0)