Commitd6fb53f

authored

bpo-39465: Remove _PyUnicode_ClearStaticStrings() from C API (GH-20078)

Remove the _PyUnicode_ClearStaticStrings() function from the C API.Make the function fully private (declare it with "static").

1 parentd72ea60 commitd6fb53fCopy full SHA for d6fb53f

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -964,3 +964,6 @@ Removed`
`964`	`964`	* ``PyTuple_ClearFreeList()``
`965`	`965`	* ``PyUnicode_ClearFreeList()``: the Unicode free list has been removed in
`966`	`966`	`Python 3.3.`
	`967`	`+`
	`968`	+* Remove ``_PyUnicode_ClearStaticStrings()`` function.
	`969`	+ (Contributed by Victor Stinner in:issue:`39465`.)

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ PyAPI_FUNC(Py_ssize_t) _Py_GetRefTotal(void);`
`36`	`36`
`37`	`37`	`PyId_foo is a static variable, either on block level or file level. On first`
`38`	`38`	`usage, the string "foo" is interned, and the structures are linked. On interpreter`
`39`		`- shutdown, all strings are released (through _PyUnicode_ClearStaticStrings).`
	`39`	`+ shutdown, all strings are released.`
`40`	`40`
`41`	`41`	`Alternatively, _Py_static_string allows choosing the variable name.`
`42`	`42`	`_PyUnicode_FromId returns a borrowed reference to the interned string.`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1215,8 +1215,6 @@ Py_DEPRECATED(3.3) PyAPI_FUNC(Py_UNICODE*) PyUnicode_AsUnicodeCopy(`
`1215`	`1215`
`1216`	`1216`	`/* Return an interned Unicode object for an Identifier; may fail if there is no memory.*/`
`1217`	`1217`	`PyAPI_FUNC(PyObject) _PyUnicode_FromId(_Py_Identifier);`
`1218`		`-/* Clear all static strings.*/`
`1219`		`-PyAPI_FUNC(void) _PyUnicode_ClearStaticStrings(void);`
`1220`	`1218`
`1221`	`1219`	`/* Fast equality check when the inputs are known to be exact unicode types`
`1222`	`1220`	`and where the hash values are equal (i.e. a very probable match)*/`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Remove the ``_PyUnicode_ClearStaticStrings()`` function from the C API.

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2289,8 +2289,8 @@ _PyUnicode_FromId(_Py_Identifier *id)`
`2289`	`2289`	`returnid->object;`
`2290`	`2290`	`}`
`2291`	`2291`
`2292`		`-void`
`2293`		`-_PyUnicode_ClearStaticStrings()`
	`2292`	`+staticvoid`
	`2293`	`+unicode_clear_static_strings(void)`
`2294`	`2294`	`{`
`2295`	`2295`	`_Py_Identifiertmp,s=static_strings;`
`2296`	`2296`	`while (s) {`
`@@ -16196,7 +16196,7 @@ _PyUnicode_Fini(PyThreadState *tstate)`
`16196`	`16196`	`Py_CLEAR(unicode_latin1[i]);`
`16197`	`16197`	`}`
`16198`	`16198`	`#endif`
`16199`		`-_PyUnicode_ClearStaticStrings();`
	`16199`	`+unicode_clear_static_strings();`
`16200`	`16200`	`}`
`16201`	`16201`
`16202`	`16202`	`_PyUnicode_FiniEncodings(tstate);`

Comments

(0)