Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc9073eb

Browse files
authored
gh-117505: Run ensurepip in isolated env in Windows installer (GH-118257)
ensurepip forks a subprocess to run pip itself, but that subprocess only inherits a -I isolated mode flag (see _run_pip() in Lib/ensurepip/__init__.py), not the "-E -s" flags that the installer has been using. This means that parts of ensurepip don't actually run in an isolated environment and can make incorrect decisions based on packages installed in the user site-packages.
1 parentbaf347d commitc9073eb

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixes an issue with the Windows installer not running ensurepip in a fully isolated environment. This could cause unexpected interactions with the user site-packages.

‎Tools/msi/pip/pip.wxs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
<?endif ?>
2626

2727
<!-- Install/uninstall pip-->
28-
<CustomActionId="SetUpdatePipCommandLine"Property="UpdatePip"Value='"[PYTHON_EXE]" -E -s -m ensurepip -U --default-pip'Execute="immediate" />
29-
<CustomActionId="SetRemovePipCommandLine"Property="UpdatePip"Value='"[PYTHON_EXE]" -E -s -B -m ensurepip._uninstall'Execute="immediate" />
28+
<CustomActionId="SetUpdatePipCommandLine"Property="UpdatePip"Value='"[PYTHON_EXE]" -I -m ensurepip -U --default-pip'Execute="immediate" />
29+
<CustomActionId="SetRemovePipCommandLine"Property="UpdatePip"Value='"[PYTHON_EXE]" -I -B -m ensurepip._uninstall'Execute="immediate" />
3030

3131
<InstallExecuteSequence>
3232
<CustomAction="SetUpdatePipCommandLine"Before="UpdatePip">(&amp;DefaultFeature=3) AND NOT (!DefaultFeature=3)</Custom>

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp