Commitc086962

authored

gh-122332: Fix missingNULL check inasyncio.Task.get_coro (#122338)

1 parent863a92f commitc086962Copy full SHA for c086962

File tree

+19

-1

lines changed

+19

-1

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -241,6 +241,18 @@ class DummyLoop:`
`241`	`241`	`_,out,err=assert_python_ok("-c",code)`
`242`	`242`	`self.assertFalse(err)`
`243`	`243`
	`244`	`+deftest_issue122332(self):`
	`245`	`+asyncdefcoro():`
	`246`	`+pass`
	`247`	`+`
	`248`	`+asyncdefrun():`
	`249`	`+task=self.loop.create_task(coro())`
	`250`	`+awaittask`
	`251`	`+self.assertIsNone(task.get_coro())`
	`252`	`+`
	`253`	`+self.run_coro(run())`
	`254`	`+`
	`255`	`+`
`244`	`256`	`classAsyncTaskCounter:`
`245`	`257`	`def__init__(self,loop,*,task_class,eager):`
`246`	`258`	`self.suspense_count=0`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fixed segfault with:meth:`asyncio.Task.get_coro` when using an eager task
	`2`	`+factory.`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2500,7 +2500,11 @@ static PyObject *`
`2500`	`2500`	`_asyncio_Task_get_coro_impl(TaskObj*self)`
`2501`	`2501`	`/[clinic end generated code: output=bcac27c8cc6c8073 input=d2e8606c42a7b403]/`
`2502`	`2502`	`{`
`2503`		`-returnPy_NewRef(self->task_coro);`
	`2503`	`+if (self->task_coro) {`
	`2504`	`+returnPy_NewRef(self->task_coro);`
	`2505`	`+ }`
	`2506`	`+`
	`2507`	`+Py_RETURN_NONE;`
`2504`	`2508`	`}`
`2505`	`2509`
`2506`	`2510`	`/*[clinic input]`

Comments

(0)