NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

Commitc06a4ff

Erlend Egeberg Aasland

authored

gh-69093: improve sqlite3.Connection.blobopen() error handling (GH-91571)

Unless sqlite3_blob_open() returns SQLITE_MISUSE, the error code andmessage are available on the connection object. This means we have tohandle SQLITE_MISUSE error messages explicitly.

1 parent1b34b56 commitc06a4ffCopy full SHA for c06a4ff

File tree

1 file changed

-1

lines changed

Modules/_sqlite
- connection.c

1 file changed

-1

lines changed

`‎Modules/_sqlite/connection.c‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,11 @@ blobopen_impl(pysqlite_Connection self, const char table, const char *col,`
`475`	`475`	`rc=sqlite3_blob_open(self->db,name,table,col,row, !readonly,&blob);`
`476`	`476`	`Py_END_ALLOW_THREADS`
`477`	`477`
`478`		`-if (rc!=SQLITE_OK) {`
	`478`	`+if (rc==SQLITE_MISUSE) {`
	`479`	`+PyErr_Format(self->state->InterfaceError,sqlite3_errstr(rc));`
	`480`	`+returnNULL;`
	`481`	`+ }`
	`482`	`+elseif (rc!=SQLITE_OK) {`
`479`	`483`	`_pysqlite_seterror(self->state,self->db);`
`480`	`484`	`returnNULL;`
`481`	`485`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc06a4ff

File tree

1 file changed

1 file changed

`‎Modules/_sqlite/connection.c‎`

0 commit comments