Commitc066bf5

authored

gh-124858: fix happy eyeballs refcyles (#124859)

1 parent6810928 commitc066bf5Copy full SHA for c066bf5

File tree

+32

-6

lines changed

+32

-6

lines changed

Lines changed: 12 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`importcollections.abc`
`18`	`18`	`importconcurrent.futures`
`19`	`19`	`importerrno`
`20`		`-importfunctools`
`21`	`20`	`importheapq`
`22`	`21`	`importitertools`
`23`	`22`	`importos`
`@@ -1140,11 +1139,18 @@ async def create_connection(`
`1140`	`1139`	`exceptOSError:`
`1141`	`1140`	`continue`
`1142`	`1141`	`else:# using happy eyeballs`
`1143`		`-sock,_,_=awaitstaggered.staggered_race(`
`1144`		`- (functools.partial(self._connect_sock,`
`1145`		`-exceptions,addrinfo,laddr_infos)`
`1146`		`-foraddrinfoininfos),`
`1147`		`-happy_eyeballs_delay,loop=self)`
	`1142`	`+sock= (awaitstaggered.staggered_race(`
	`1143`	`+ (`
	`1144`	`+# can't use functools.partial as it keeps a reference`
	`1145`	`+# to exceptions`
	`1146`	`+lambdaaddrinfo=addrinfo:self._connect_sock(`
	`1147`	`+exceptions,addrinfo,laddr_infos`
	`1148`	`+ )`
	`1149`	`+foraddrinfoininfos`
	`1150`	`+ ),`
	`1151`	`+happy_eyeballs_delay,`
	`1152`	`+loop=self,`
	`1153`	`+ ))[0]# can't use sock, _, _ as it keeks a reference to exceptions`
`1148`	`1154`
`1149`	`1155`	`ifsockisNone:`
`1150`	`1156`	`exceptions= [excforsubinexceptionsforexcinsub]`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ async def run_one_coro(previous_failed) -> None:`
`133`	`133`	`raised.exception()`
`134`	`134`	`returnwinner_result,winner_index,exceptions`
`135`	`135`	`finally:`
	`136`	`+delexceptions`
`136`	`137`	`# Make sure no tasks are left running if we leave this function`
`137`	`138`	`fortinrunning_tasks:`
`138`	`139`	`t.cancel()`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1200,6 +1200,24 @@ async def handle_echo(reader, writer):`
`1200`	`1200`	`messages=self._basetest_unhandled_exceptions(handle_echo)`
`1201`	`1201`	`self.assertEqual(messages, [])`
`1202`	`1202`
	`1203`	`+deftest_open_connection_happy_eyeball_refcycles(self):`
	`1204`	`+port=socket_helper.find_unused_port()`
	`1205`	`+asyncdefmain():`
	`1206`	`+exc=None`
	`1207`	`+try:`
	`1208`	`+awaitasyncio.open_connection(`
	`1209`	`+host="localhost",`
	`1210`	`+port=port,`
	`1211`	`+happy_eyeballs_delay=0.25,`
	`1212`	`+ )`
	`1213`	`+ except*OSErrorasexcs:`
	`1214`	`+# can't use assertRaises because that clears frames`
	`1215`	`+exc=excs.exceptions[0]`
	`1216`	`+self.assertIsNotNone(exc)`
	`1217`	`+self.assertListEqual(gc.get_referrers(exc), [])`
	`1218`	`+`
	`1219`	`+asyncio.run(main())`
	`1220`	`+`
`1203`	`1221`
`1204`	`1222`	`if__name__=='__main__':`
`1205`	`1223`	`unittest.main()`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix reference cycles left in tracebacks in:func:`asyncio.open_connection` when used with ``happy_eyeballs_delay``

Comments

(0)