Commitbf0adb9

committed

Address code review

1 parent6f8b69f commitbf0adb9Copy full SHA for bf0adb9

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -720,7 +720,7 @@ gen_set_name(PyObject self, PyObject value, void *Py_UNUSED(ignored))`
`720`	`720`	`return-1;`
`721`	`721`	`}`
`722`	`722`	`Py_BEGIN_CRITICAL_SECTION(self);`
`723`		`-_PyObject_XSetRefDelayed(&op->gi_name,value);`
	`723`	`+_PyObject_XSetRefDelayed(&op->gi_name,Py_NewRef(value));`
`724`	`724`	`Py_END_CRITICAL_SECTION();`
`725`	`725`	`return0;`
`726`	`726`	`}`
`@@ -744,7 +744,7 @@ gen_set_qualname(PyObject self, PyObject value, void *Py_UNUSED(ignored))`
`744`	`744`	`return-1;`
`745`	`745`	`}`
`746`	`746`	`Py_BEGIN_CRITICAL_SECTION(self);`
`747`		`-_PyObject_XSetRefDelayed(&op->gi_qualname,value);`
	`747`	`+_PyObject_XSetRefDelayed(&op->gi_qualname,Py_NewRef(value));`
`748`	`748`	`Py_END_CRITICAL_SECTION();`
`749`	`749`	`return0;`
`750`	`750`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1931,7 +1931,7 @@ PyObject_GenericSetDict(PyObject obj, PyObject value, void *context)`
`1931`	`1931`	`return-1;`
`1932`	`1932`	`}`
`1933`	`1933`	`Py_BEGIN_CRITICAL_SECTION(obj);`
`1934`		`-_PyObject_XSetRefDelayed(dictptr,value);`
	`1934`	`+_PyObject_XSetRefDelayed(dictptr,Py_NewRef(value));`
`1935`	`1935`	`Py_END_CRITICAL_SECTION();`
`1936`	`1936`	`return0;`
`1937`	`1937`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1236,7 +1236,7 @@ void`
`1236`	`1236`	`_PyObject_XSetRefDelayed(PyObject*ptr,PyObjectvalue)`
`1237`	`1237`	`{`
`1238`	`1238`	`PyObjectold=ptr;`
`1239`		`-FT_ATOMIC_STORE_PTR_RELEASE(*ptr,Py_NewRef(value));`
	`1239`	`+FT_ATOMIC_STORE_PTR_RELEASE(*ptr,value);`
`1240`	`1240`	`_PyObject_XDecRefDelayed(old);`
`1241`	`1241`	`}`
`1242`	`1242`	`#endif`

Comments

(0)