Commita29998a

authored

gh-116325: RaiseSyntaxError rather thanIndexError on ForwardRef with empty string arg (#116341)

1 parentffcc450 commita29998aCopy full SHA for a29998a

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5867,6 +5867,12 @@ def foo(a: 'Node[T'):`
`5867`	`5867`	`withself.assertRaises(SyntaxError):`
`5868`	`5868`	`get_type_hints(foo)`
`5869`	`5869`
	`5870`	`+deftest_syntax_error_empty_string(self):`
	`5871`	`+forformin [typing.List,typing.Set,typing.Type,typing.Deque]:`
	`5872`	`+withself.subTest(form=form):`
	`5873`	`+withself.assertRaises(SyntaxError):`
	`5874`	`+form['']`
	`5875`	`+`
`5870`	`5876`	`deftest_name_error(self):`
`5871`	`5877`
`5872`	`5878`	`deffoo(a:'Noode[T]'):`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -880,7 +880,7 @@ def __init__(self, arg, is_argument=True, module=None, *, is_class=False):`
`880`	`880`	# If we do `def f(args: Ts)`, then we'll have `arg = '*Ts'`.
`881`	`881`	`# Unfortunately, this isn't a valid expression on its own, so we`
`882`	`882`	`# do the unpacking manually.`
`883`		`-ifarg[0]=='*':`
	`883`	`+ifarg.startswith('*'):`
`884`	`884`	`arg_to_compile=f'({arg},)[0]'# E.g. (Ts,)[0] or (tuple[int, int],)[0]`
`885`	`885`	`else:`
`886`	`886`	`arg_to_compile=arg`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+:mod:`typing`: raise:exc:`SyntaxError` instead of:exc:`AttributeError`
	`2`	`+on forward references as empty strings.`

Comments

(0)