Commit980aa20

committed

Address review

1 parentf64b60b commit980aa20Copy full SHA for 980aa20

File tree

-16

lines changed

-16

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -94,11 +94,11 @@ def cleanup():`
`94`	`94`
`95`	`95`	`delast.AST._fields`
`96`	`96`
`97`		`-msg='AST has nofields'`
	`97`	`+msg="type object 'ast.AST' has noattribute '_fields'"`
`98`	`98`	`# Both examples used to crash:`
`99`		`-withself.assertRaisesRegex(TypeError,msg):`
	`99`	`+withself.assertRaisesRegex(AttributeError,msg):`
`100`	`100`	`ast.AST(arg1=123)`
`101`		`-withself.assertRaisesRegex(TypeError,msg):`
	`101`	`+withself.assertRaisesRegex(AttributeError,msg):`
`102`	`102`	`ast.AST()`
`103`	`103`
`104`	`104`	`deftest_AST_garbage_collection(self):`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Fix a crash in:mod:`ast` when``_fields`` attribute is deleted.
	`1`	+Fix a crash in:mod:`ast` whenthe:attr:`ast.AST._fields` attribute is deleted.

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -884,13 +884,9 @@ def visitModule(self, mod):`
`884`	`884`	`Py_ssize_t i, numfields = 0;`
`885`	`885`	`int res = -1;`
`886`	`886`	`PyObject key, value, fields, attributes = NULL, *remaining_fields = NULL;`
`887`		`- if (PyObject_GetOptionalAttr((PyObject*)Py_TYPE(self), state->_fields, &fields) < 0) {`
`888`		`- goto cleanup;`
`889`		`- }`
	`887`	`+`
	`888`	`+ fields = PyObject_GetAttr((PyObject*)Py_TYPE(self), state->_fields);`
`890`	`889`	`if (fields == NULL) {`
`891`		`- PyErr_Format(PyExc_TypeError,`
`892`		`- "%.400s has no fields",`
`893`		`- _PyType_Name(Py_TYPE(self)));`
`894`	`890`	`goto cleanup;`
`895`	`891`	`}`
`896`	`892`

Lines changed: 2 additions & 6 deletions

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Comments

(0)