Commit9063e79

committed

[tests] test_subprocess maybe avoid a timeout race condition?

The few buildbot failures on#133103are possibly just due to racing a child process launch and exit?

1 parent2bbcaed commit9063e79Copy full SHA for 9063e79

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -164,13 +164,13 @@ def test_call_timeout(self):`
`164`	`164`
`165`	`165`	`deftest_timeout_exception(self):`
`166`	`166`	`try:`
`167`		`-subprocess.run(['echo','hi'],timeout=-1)`
	`167`	`+subprocess.run([sys.executable,'-c','import time;time.sleep(9)'],timeout=-1)`
`168`	`168`	`exceptsubprocess.TimeoutExpiredase:`
`169`	`169`	`self.assertIn("-1 seconds",str(e))`
`170`	`170`	`else:`
`171`	`171`	`self.fail("Expected TimeoutExpired exception not raised")`
`172`	`172`	`try:`
`173`		`-subprocess.run(['echo','hi'],timeout=0)`
	`173`	`+subprocess.run([sys.executable,'-c','import time;time.sleep(9)'],timeout=0)`
`174`	`174`	`exceptsubprocess.TimeoutExpiredase:`
`175`	`175`	`self.assertIn("0 seconds",str(e))`
`176`	`176`	`else:`

Comments

(0)