Commit8c5e555

authored

GH-131798: Turn _LOAD_SMALL_INT into _LOAD_CONST_INLINE_BORROW in the JIT (GH-134406)

1 parent3effede commit8c5e555Copy full SHA for 8c5e555

File tree

+21

-2

lines changed

+21

-2

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2156,6 +2156,18 @@ def testfunc(n):`
`2156`	`2156`	`self.assertIn("_GUARD_TYPE_VERSION",uops)`
`2157`	`2157`	`self.assertNotIn("_CHECK_ATTR_CLASS",uops)`
`2158`	`2158`
	`2159`	`+deftest_load_small_int(self):`
	`2160`	`+deftestfunc(n):`
	`2161`	`+x=0`
	`2162`	`+foriinrange(n):`
	`2163`	`+x+=1`
	`2164`	`+returnx`
	`2165`	`+res,ex=self._run_with_optimizer(testfunc,TIER2_THRESHOLD)`
	`2166`	`+self.assertEqual(res,TIER2_THRESHOLD)`
	`2167`	`+self.assertIsNotNone(ex)`
	`2168`	`+uops=get_opnames(ex)`
	`2169`	`+self.assertNotIn("_LOAD_SMALL_INT",uops)`
	`2170`	`+self.assertIn("_LOAD_CONST_INLINE_BORROW",uops)`
`2159`	`2171`
`2160`	`2172`	`defglobal_identity(x):`
`2161`	`2173`	`returnx`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+JIT: replace ``_LOAD_SMALL_INT`` with ``_LOAD_CONST_INLINE_BORROW``

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -528,7 +528,10 @@ dummy_func(void) {`
`528`	`528`	`}`
`529`	`529`
`530`	`530`	`op(_LOAD_SMALL_INT, (--value)) {`
`531`		`-PyObject*val=PyLong_FromLong(this_instr->oparg);`
	`531`	`+PyObject*val=PyLong_FromLong(oparg);`
	`532`	`+assert(val);`
	`533`	`+assert(_Py_IsImmortal(val));`
	`534`	`+REPLACE_OP(this_instr,_LOAD_CONST_INLINE_BORROW,0, (uintptr_t)val);`
`532`	`535`	`value=sym_new_const(ctx,val);`
`533`	`536`	`}`
`534`	`537`

Lines changed: 4 additions & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Comments

(0)