Commit8acbb93

and

authored

bpo-43292: Fix file leak inET.iterparse() when not exhausted (GH-31696)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>(cherry picked from commit496c428)Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>

1 parentee18df4 commit8acbb93Copy full SHA for 8acbb93

File tree

+20

-7

lines changed

+20

-7

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -658,6 +658,14 @@ def test_iterparse(self):`
`658`	`658`	`'junk after document element: line 1, column 12')`
`659`	`659`	`delcm,it`
`660`	`660`
	`661`	`+# Not exhausting the iterator still closes the resource (bpo-43292)`
	`662`	`+withwarnings_helper.check_no_resource_warning(self):`
	`663`	`+it=iterparse(TESTFN)`
	`664`	`+delit`
	`665`	`+`
	`666`	`+withself.assertRaises(FileNotFoundError):`
	`667`	`+iterparse("nonexistent")`
	`668`	`+`
`661`	`669`	`deftest_writefile(self):`
`662`	`670`	`elem=ET.Element("tag")`
`663`	`671`	`elem.text="text"`

Lines changed: 9 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1248,8 +1248,14 @@ def iterparse(source, events=None, parser=None):`
`1248`	`1248`	`# Use the internal, undocumented _parser argument for now; When the`
`1249`	`1249`	`# parser argument of iterparse is removed, this can be killed.`
`1250`	`1250`	`pullparser=XMLPullParser(events=events,_parser=parser)`
`1251`		`-defiterator():`
	`1251`	`+`
	`1252`	`+defiterator(source):`
	`1253`	`+close_source=False`
`1252`	`1254`	`try:`
	`1255`	`+ifnothasattr(source,"read"):`
	`1256`	`+source=open(source,"rb")`
	`1257`	`+close_source=True`
	`1258`	`+yieldNone`
`1253`	`1259`	`whileTrue:`
`1254`	`1260`	`yieldfrompullparser.read_events()`
`1255`	`1261`	`# load event buffer`
`@@ -1265,16 +1271,12 @@ def iterator():`
`1265`	`1271`	`source.close()`
`1266`	`1272`
`1267`	`1273`	`classIterParseIterator(collections.abc.Iterator):`
`1268`		`-__next__=iterator().__next__`
	`1274`	`+__next__=iterator(source).__next__`
`1269`	`1275`	`it=IterParseIterator()`
`1270`	`1276`	`it.root=None`
`1271`	`1277`	`deliterator,IterParseIterator`
`1272`	`1278`
`1273`		`-close_source=False`
`1274`		`-ifnothasattr(source,"read"):`
`1275`		`-source=open(source,"rb")`
`1276`		`-close_source=True`
`1277`		`-`
	`1279`	`+next(it)`
`1278`	`1280`	`returnit`
`1279`	`1281`
`1280`	`1282`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1870,6 +1870,7 @@ Wojtek Walczak`
`1870`	`1870`	`Charles Waldman`
`1871`	`1871`	`Richard Walker`
`1872`	`1872`	`Larry Wall`
	`1873`	`+Jacob Walls`
`1873`	`1874`	`Kevin Walzer`
`1874`	`1875`	`Rodrigo Steinmuller Wanderley`
`1875`	`1876`	`Dingyuan Wang`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fixed a file leak in:func:`xml.etree.ElementTree.iterparse` when the
	`2`	`+iterator is not exhausted. Patch by Jacob Walls.`

Comments

(0)