Commit87a865e

and

authored

bpo-34767: Do not always create a collections.deque() in asyncio.Lock() (GH-13834)

https://bugs.python.org/issue34767(cherry picked from commit9aa7856)Co-authored-by: Zackery Spytz <zspytz@gmail.com>

1 parentf2054d9 commit87a865eCopy full SHA for 87a865e

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ class Lock(_ContextManagerMixin):`
`158`	`158`	`"""`
`159`	`159`
`160`	`160`	`def__init__(self,*,loop=None):`
`161`		`-self._waiters=collections.deque()`
	`161`	`+self._waiters=None`
`162`	`162`	`self._locked=False`
`163`	`163`	`ifloopisnotNone:`
`164`	`164`	`self._loop=loop`
`@@ -182,10 +182,13 @@ async def acquire(self):`
`182`	`182`	`This method blocks until the lock is unlocked, then sets it to`
`183`	`183`	`locked and returns True.`
`184`	`184`	`"""`
`185`		`-ifnotself._lockedandall(w.cancelled()forwinself._waiters):`
	`185`	`+if (notself._lockedand (self._waitersisNoneor`
	`186`	`+all(w.cancelled()forwinself._waiters))):`
`186`	`187`	`self._locked=True`
`187`	`188`	`returnTrue`
`188`	`189`
	`190`	`+ifself._waitersisNone:`
	`191`	`+self._waiters=collections.deque()`
`189`	`192`	`fut=self._loop.create_future()`
`190`	`193`	`self._waiters.append(fut)`
`191`	`194`
`@@ -224,6 +227,8 @@ def release(self):`
`224`	`227`
`225`	`228`	`def_wake_up_first(self):`
`226`	`229`	`"""Wake up the first waiter if it isn't done."""`
	`230`	`+ifnotself._waiters:`
	`231`	`+return`
`227`	`232`	`try:`
`228`	`233`	`fut=next(iter(self._waiters))`
`229`	`234`	`exceptStopIteration:`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Do not always create a:class:`collections.deque` in:class:`asyncio.Lock`.

Comments

(0)