Commit86d1a1a

authored

gh-119555: catch SyntaxError from compile() in the InteractiveColoredConsole (#119557)

1 parentc0faade commit86d1a1aCopy full SHA for 86d1a1a

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ def runsource(self, source, filename="<input>", symbol="single"):`
`101`	`101`	`item=wrapper([stmt])`
`102`	`102`	`try:`
`103`	`103`	`code=compile(item,filename,the_symbol,dont_inherit=True)`
`104`		`-except (OverflowError,ValueError):`
	`104`	`+except (OverflowError,ValueError,SyntaxError):`
`105`	`105`	`self.showsyntaxerror(filename)`
`106`	`106`	`returnFalse`
`107`	`107`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,14 @@ def test_runsource_shows_syntax_error_for_failed_compilation(self):`
`94`	`94`	`withpatch.object(console,"showsyntaxerror")asmock_showsyntaxerror:`
`95`	`95`	`console.runsource(source)`
`96`	`96`	`mock_showsyntaxerror.assert_called_once()`
	`97`	`+source=dedent("""\`
	`98`	`+ match 1:`
	`99`	`+ case {0: _, 0j: _}:`
	`100`	`+ pass`
	`101`	`+ """)`
	`102`	`+withpatch.object(console,"showsyntaxerror")asmock_showsyntaxerror:`
	`103`	`+console.runsource(source)`
	`104`	`+mock_showsyntaxerror.assert_called_once()`
`97`	`105`
`98`	`106`	`deftest_no_active_future(self):`
`99`	`107`	`console=InteractiveColoredConsole()`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Catch:exc:`SyntaxError` from:func:`compile` in the runsource() method of
	`2`	`+the InteractiveColoredConsole. Patch by Sergey B Kirpichev.`

Comments

(0)