Commit86c29f5

committed

test that http.client _tunnel closes the response on exceptions

1 parent5500734 commit86c29f5Copy full SHA for 86c29f5

File tree

+25

-4

lines changed

+25

-4

lines changed

Lines changed: 25 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2383,12 +2383,33 @@ def test_tunnel_debuglog(self):`
`2383`	`2383`
`2384`	`2384`	`self.conn.set_debuglevel(1)`
`2385`	`2385`	`self.conn._create_connection=self._create_connection(response_text)`
	`2386`	`+self.conn.set_tunnel("destination.com")`
	`2387`	`+self.conn.request('HEAD','/','')`
	`2388`	`+`
	`2389`	`+`
	`2390`	`+deftest_tunnel_leak(self):`
	`2391`	`+sock=None`
	`2392`	`+`
	`2393`	`+def_create_connection(address,timeout=None,source_address=None):`
	`2394`	`+nonlocalsock`
	`2395`	`+sock=FakeSocket(`
	`2396`	`+'HTTP/1.1 404 NOT FOUND\r\n\r\n',`
	`2397`	`+host=address[0],`
	`2398`	`+port=address[1],`
	`2399`	`+ )`
	`2400`	`+returnsock`
	`2401`	`+`
	`2402`	`+self.conn._create_connection=_create_connection`
`2386`	`2403`	`self.conn.set_tunnel('destination.com')`
	`2404`	`+exc=None`
	`2405`	`+try:`
	`2406`	`+self.conn.request('HEAD','/','')`
	`2407`	`+exceptOSErrorase:`
	`2408`	`+# keeping a reference to exc keeps response alive in the traceback`
	`2409`	`+exc=e`
	`2410`	`+self.assertIsNotNone(exc)`
	`2411`	`+self.assertTrue(sock.file_closed)`
`2387`	`2412`
`2388`		`-withsupport.captured_stdout()asoutput:`
`2389`		`-self.conn.request('PUT','/','')`
`2390`		`-lines=output.getvalue().splitlines()`
`2391`		`-self.assertIn('header: {}'.format(expected_header),lines)`
`2392`	`2413`
`2393`	`2414`
`2394`	`2415`	`if__name__=='__main__':`

Comments

(0)