Commit8421b03

and

authored

gh-134235: Import Autocomplete for Builtin Modules (GH-134277)

* added enhancement auto completing import with sys builtins---------Co-authored-by: Hunter <hyoung3@gmail.com>

1 parent4709417 commit8421b03Copy full SHA for 8421b03

File tree

+25

-2

lines changed

+25

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,9 @@ def find_modules(self, path: str, prefix: str) -> list[str]:`
`81`	`81`	`def_find_modules(self,path:str,prefix:str)->list[str]:`
`82`	`82`	`ifnotpath:`
`83`	`83`	# Top-level import (e.g. `import foo<tab>`` or `from foo<tab>`)`
`84`		`-return [namefor_,name,_inself.global_cache`
`85`		`-ifname.startswith(prefix)]`
	`84`	`+builtin_modules= [namefornameinsys.builtin_module_namesifname.startswith(prefix)]`
	`85`	`+third_party_modules= [namefor_,name,_inself.global_cacheifname.startswith(prefix)]`
	`86`	`+returnsorted(builtin_modules+third_party_modules)`
`86`	`87`
`87`	`88`	`ifpath.startswith('.'):`
`88`	`89`	`# Convert relative path to absolute path`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -959,6 +959,26 @@ def test_import_completions(self):`
`959`	`959`	`output=reader.readline()`
`960`	`960`	`self.assertEqual(output,expected)`
`961`	`961`
	`962`	`+deftest_builtin_completion_top_level(self):`
	`963`	`+importimportlib`
	`964`	`+# Make iter_modules() search only the standard library.`
	`965`	`+# This makes the test more reliable in case there are`
	`966`	`+# other user packages/scripts on PYTHONPATH which can`
	`967`	`+# intefere with the completions.`
	`968`	`+lib_path=os.path.dirname(importlib.__path__[0])`
	`969`	`+sys.path= [lib_path]`
	`970`	`+`
	`971`	`+cases= (`
	`972`	`+ ("import bui\t\n","import builtins"),`
	`973`	`+ ("from bui\t\n","from builtins"),`
	`974`	`+ )`
	`975`	`+forcode,expectedincases:`
	`976`	`+withself.subTest(code=code):`
	`977`	`+events=code_to_events(code)`
	`978`	`+reader=self.prepare_reader(events,namespace={})`
	`979`	`+output=reader.readline()`
	`980`	`+self.assertEqual(output,expected)`
	`981`	`+`
`962`	`982`	`deftest_relative_import_completions(self):`
`963`	`983`	`cases= (`
`964`	`984`	`("from .readl\t\n","from .readline"),`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Updated tab completion on REPL to include builtin modules. Contributed by`
	`2`	`+Tom Wang, Hunter Young`

Comments

(0)