Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit81148c6

Browse files
bpo-45001: Make email date parsing more robust against malformed input (GH-27946) (GH-27974)
Various date parsing utilities in the email module, such asemail.utils.parsedate(), are supposed to gracefully handle invalidinput, typically by raising an appropriate exception or by returningNone.The internal email._parseaddr._parsedate_tz() helper used by some ofthese date parsing routines tries to be robust against malformed input,but unfortunately it can still crash ungracefully when a non-empty butwhitespace-only input is passed. This manifests as an unexpectedIndexError.In practice, this can happen when parsing an email with only a newlineinside a ‘Date:’ header, which unfortunately happens occasionally in thereal world.Here's a minimal example: $ python Python 3.9.6 (default, Jun 30 2021, 10:22:16) [GCC 11.1.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import email.utils >>> email.utils.parsedate('foo') >>> email.utils.parsedate(' ') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.9/email/_parseaddr.py", line 176, in parsedate t = parsedate_tz(data) File "/usr/lib/python3.9/email/_parseaddr.py", line 50, in parsedate_tz res = _parsedate_tz(data) File "/usr/lib/python3.9/email/_parseaddr.py", line 72, in _parsedate_tz if data[0].endswith(',') or data[0].lower() in _daynames: IndexError: list index out of rangeThe fix is rather straight-forward: guard against empty lists, aftersplitting on whitespace, but before accessing the first element.(cherry picked from commit989f6a3)Co-authored-by: wouter bolsterlee <wouter@bolsterl.ee>
1 parent6ebfe8d commit81148c6

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

‎Lib/email/_parseaddr.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ def _parsedate_tz(data):
6767
ifnotdata:
6868
return
6969
data=data.split()
70+
ifnotdata:# This happens for whitespace-only input.
71+
returnNone
7072
# The FWS after the comma after the day-of-week is optional, so search and
7173
# adjust for this.
7274
ifdata[0].endswith(',')ordata[0].lower()in_daynames:

‎Lib/test/test_email/test_email.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3002,6 +3002,8 @@ def test_formatdate_usegmt(self):
30023002
deftest_parsedate_returns_None_for_invalid_strings(self):
30033003
self.assertIsNone(utils.parsedate(''))
30043004
self.assertIsNone(utils.parsedate_tz(''))
3005+
self.assertIsNone(utils.parsedate(' '))
3006+
self.assertIsNone(utils.parsedate_tz(' '))
30053007
self.assertIsNone(utils.parsedate('0'))
30063008
self.assertIsNone(utils.parsedate_tz('0'))
30073009
self.assertIsNone(utils.parsedate('A Complete Waste of Time'))
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Made email date parsing more robust against malformed input, namely a
2+
whitespace-only ``Date:`` header. Patch by Wouter Bolsterlee.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp