Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Commit7fcace9
Add the following private methods to `pathlib.Path.info`:- `_posix_permissions()`: the POSIX file permissions (`S_IMODE(st_mode)`)- `_file_id()`: the file ID (`(st_dev, st_ino)`)- `_access_time_ns()`: the access time in nanoseconds (`st_atime_ns`)- `_mod_time_ns()`: the modify time in nanoseconds (`st_mtime_ns`)- `_bsd_flags()`: the BSD file flags (`st_flags`)- `_xattrs()`: the file extended attributes as a list of key, value pairs, or an empty list if `listxattr()` or `getxattr()` fail in an ignorable way.These methods replace `LocalCopyReader.read_metadata()`, and so we candelete the `CopyReader` and `LocalCopyReader` classes. Rather than readingmetadata via `source._copy_reader.read_metadata()`, we instead call`source.info._posix_permissions()`, `_access_time_ns()`, etc.Preserving metadata is only supported for local-to-local copies at themoment. To support copying metadata between arbitrary `ReadablePath` and`WritablePath` objects, we'd need to make the new methods public anddocumented.Co-authored-by: Petr Viktorin <encukou@gmail.com>
1 parentbd1642c commit7fcace9
File tree
4 files changed
+204
-206
lines changed- Lib
- pathlib
- test/test_pathlib
4 files changed
+204
-206
lines changedLines changed: 1 addition & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
14 | 14 |
| |
15 | 15 |
| |
16 | 16 |
| |
17 |
| - | |
| 17 | + | |
18 | 18 |
| |
19 | 19 |
| |
20 | 20 |
| |
| |||
353 | 353 |
| |
354 | 354 |
| |
355 | 355 |
| |
356 |
| - | |
357 |
| - | |
358 | 356 |
| |
359 | 357 |
| |
360 | 358 |
| |
|
Lines changed: 2 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
22 |
| - | |
| 22 | + | |
23 | 23 |
| |
24 | 24 |
| |
25 | 25 |
| |
| |||
1079 | 1079 |
| |
1080 | 1080 |
| |
1081 | 1081 |
| |
1082 |
| - | |
1083 | 1082 |
| |
1084 | 1083 |
| |
1085 | 1084 |
| |
| |||
1125 | 1124 |
| |
1126 | 1125 |
| |
1127 | 1126 |
| |
1128 |
| - | |
| 1127 | + | |
1129 | 1128 |
| |
1130 | 1129 |
| |
1131 | 1130 |
| |
|
0 commit comments
Comments
(0)