Commit68a8ca6

authored

Fix potential refleak if PyModule_AddObject() fails.

1 parent22f3425 commit68a8ca6Copy full SHA for 68a8ca6

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -730,9 +730,11 @@ PyInit__io(void)`
`730`	`730`	`"UnsupportedOperation",PyExc_OSError,PyExc_ValueError);`
`731`	`731`	`if (state->unsupported_operation==NULL)`
`732`	`732`	`gotofail;`
`733`		`-if (PyModule_AddObject(m,"UnsupportedOperation",`
`734`		`-Py_NewRef(state->unsupported_operation))<0)`
	`733`	`+if (PyModule_AddObjectRef(m,"UnsupportedOperation",`
	`734`	`+state->unsupported_operation)<0)`
	`735`	`+ {`
`735`	`736`	`gotofail;`
	`737`	`+ }`
`736`	`738`
`737`	`739`	`/* BlockingIOError, for compatibility */`
`738`	`740`	`if (PyModule_AddObjectRef(m,"BlockingIOError",`
`@@ -785,7 +787,6 @@ PyInit__io(void)`
`785`	`787`	`returnm;`
`786`	`788`
`787`	`789`	`fail:`
`788`		`-Py_XDECREF(state->unsupported_operation);`
`789`	`790`	`Py_DECREF(m);`
`790`	`791`	`returnNULL;`
`791`	`792`	`}`

Comments

(0)