Commit677b0e3

and

authored

[3.14]gh-136523: Fix wave.Wave_write emitting an unraisable when open raises (GH-136529) (GH-136606)

(cherry picked from commit171de05)Co-authored-by: Sachin Shah <39803835+inventshah@users.noreply.github.com>

1 parentcdf98c3 commit677b0e3Copy full SHA for 677b0e3

File tree

+12

-0

lines changed

+12

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`fromtestimportaudiotests`
`3`	`3`	`fromtestimportsupport`
`4`	`4`	`importio`
	`5`	`+importos`
`5`	`6`	`importstruct`
`6`	`7`	`importsys`
`7`	`8`	`importwave`
`@@ -222,6 +223,14 @@ def test_read_wrong_sample_width(self):`
`222`	`223`	`withself.assertRaisesRegex(wave.Error,'bad sample width'):`
`223`	`224`	`wave.open(io.BytesIO(b))`
`224`	`225`
	`226`	`+deftest_open_in_write_raises(self):`
	`227`	`+# gh-136523: Wave_write.__del__ should not throw`
	`228`	`+withsupport.catch_unraisable_exception()ascm:`
	`229`	`+withself.assertRaises(OSError):`
	`230`	`+wave.open(os.curdir,"wb")`
	`231`	`+support.gc_collect()`
	`232`	`+self.assertIsNone(cm.unraisable)`
	`233`	`+`
`225`	`234`
`226`	`235`	`if__name__=='__main__':`
`227`	`236`	`unittest.main()`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -441,6 +441,8 @@ class Wave_write:`
`441`	`441`	`_datawritten -- the size of the audio samples actually written`
`442`	`442`	`"""`
`443`	`443`
	`444`	`+_file=None`
	`445`	`+`
`444`	`446`	`def__init__(self,f):`
`445`	`447`	`self._i_opened_the_file=None`
`446`	`448`	`ifisinstance(f,str):`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix:class:`wave.Wave_write` emitting an unraisable when open raises.

Comments

(0)