Commit5dd3673

authored

gh-74929: Remove undesirable DECREF in PEP 667 implementation (#118583)

With tests.

1 parent1b22d80 commit5dd3673Copy full SHA for 5dd3673

File tree

+15

-1

lines changed

+15

-1

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -364,6 +364,21 @@ def f():`
`364`	`364`	`c=0`
`365`	`365`	`f()`
`366`	`366`
	`367`	`+deftest_local_objects(self):`
	`368`	`+o=object()`
	`369`	`+k='.'.join(['a','b','c'])`
	`370`	`+f_locals=sys._getframe().f_locals`
	`371`	`+f_locals['o']=f_locals['k']`
	`372`	`+self.assertEqual(o,'a.b.c')`
	`373`	`+`
	`374`	`+deftest_update_with_self(self):`
	`375`	`+deff():`
	`376`	`+f_locals=sys._getframe().f_locals`
	`377`	`+f_locals.update(f_locals)`
	`378`	`+f_locals.update(f_locals)`
	`379`	`+f_locals.update(f_locals)`
	`380`	`+f()`
	`381`	`+`
`367`	`382`	`deftest_repr(self):`
`368`	`383`	`x=1`
`369`	`384`	`# Introduce a reference cycle`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,6 @@ framelocalsproxy_setitem(PyObject self, PyObject key, PyObject *value)`
`171`	`171`	`}elseif (value!=oldvalue) {`
`172`	`172`	`Py_XSETREF(fast[i],Py_NewRef(value));`
`173`	`173`	`}`
`174`		`-Py_XDECREF(value);`
`175`	`174`	`return0;`
`176`	`175`	`}`
`177`	`176`	`}`

Comments

(0)