Commit5c3c953

committed

gh-133745: Fix asyncio task factory name/context kwarg breaks

1 parent05ddd06 commit5c3c953Copy full SHA for 5c3c953

File tree

+13

-3

lines changed

+13

-3

lines changed

Lines changed: 13 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -458,16 +458,26 @@ def create_future(self):`
`458`	`458`	`"""Create a Future object attached to the loop."""`
`459`	`459`	`returnfutures.Future(loop=self)`
`460`	`460`
`461`		`-defcreate_task(self,coro,**kwargs):`
	`461`	`+defcreate_task(self,coro,,name=None,context=None,*kwargs):`
`462`	`462`	`"""Schedule a coroutine object.`
`463`	`463`
`464`	`464`	`Return a task object.`
`465`	`465`	`"""`
`466`	`466`	`self._check_closed()`
`467`	`467`	`ifself._task_factoryisnotNone:`
`468`		`-returnself._task_factory(self,coro,**kwargs)`
	`468`	`+ifcontextisnotNone:`
	`469`	`+kwargs["context"]=context`
`469`	`470`
`470`		`-task=tasks.Task(coro,loop=self,**kwargs)`
	`471`	`+task=self._task_factory(self,coro,**kwargs)`
	`472`	`+task.set_name(name)`
	`473`	`+try:`
	`474`	`+# gh-128552: prevent a refcycle of`
	`475`	`+# task.exception().__traceback__->BaseEventLoop.create_task->task`
	`476`	`+returntask`
	`477`	`+finally:`
	`478`	`+deltask`
	`479`	`+`
	`480`	`+task=tasks.Task(coro,loop=self,name=name,context=context,**kwargs)`
`471`	`481`	`iftask._source_traceback:`
`472`	`482`	`deltask._source_traceback[-1]`
`473`	`483`	`try:`

Comments

(0)