Commit5804ee7

authored

gh-114177: avoid calling connection lost callbacks when loop is already closed in asyncio subprocess (#134508)

1 parent8dbc119 commit5804ee7Copy full SHA for 5804ee7

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,12 @@ def close(self):`
`104`	`104`	`forprotoinself._pipes.values():`
`105`	`105`	`ifprotoisNone:`
`106`	`106`	`continue`
`107`		`-proto.pipe.close()`
	`107`	`+# See gh-114177`
	`108`	`+# skip closing the pipe if loop is already closed`
	`109`	`+# this can happen e.g. when loop is closed immediately after`
	`110`	`+# process is killed`
	`111`	`+ifself._loopandnotself._loop.is_closed():`
	`112`	`+proto.pipe.close()`
`108`	`113`
`109`	`114`	`if (self._procisnotNoneand`
`110`	`115`	`# has the child process finished?`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix:mod:`asyncio` to not close subprocess pipes which would otherwise error out when the event loop is already closed.

Comments

(0)