Commit56d73b9

committed

gh-62948: IOBase finalizer logs close() exceptions

1 parent4b65d56 commit56d73b9Copy full SHA for 56d73b9

File tree

+13

-12

lines changed

+13

-12

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,15 @@ New Modules`
`87`	`87`	`Improved Modules`
`88`	`88`	`================`
`89`	`89`
	`90`	`+io`
	`91`	`+--`
	`92`	`+`
	`93`	+The:class:`io.IOBase` finalizer now logs the ``close()`` method errors with
	`94`	+:data:`sys.excepthook`. Previously, errors were ignored silently by default,
	`95`	+and only logged in:ref:`Python Development Mode<devmode>` or on:ref:`Python
	`96`	+built on debug mode <debug-build>`.
	`97`	+(Contributed by Victor Stinner in:gh:`62948`.)
	`98`	`+`
`90`	`99`	`pathlib`
`91`	`100`	`-------`
`92`	`101`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,4 @@`
	`1`	+The:class:`io.IOBase` finalizer now logs the ``close()`` method errors with
	`2`	+:data:`sys.excepthook`. Previously, errors were ignored silently by default,
	`3`	+and only logged in:ref:`Python Development Mode<devmode>` or on
	`4`	+:ref:`Python built on debug mode<debug-build>`. Patch by Victor Stinner.

Lines changed: 0 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -319,20 +319,8 @@ iobase_finalize(PyObject *self)`
`319`	`319`	`if (PyObject_SetAttr(self,&_Py_ID(_finalizing),Py_True))`
`320`	`320`	`PyErr_Clear();`
`321`	`321`	`res=PyObject_CallMethodNoArgs((PyObject*)self,&_Py_ID(close));`
`322`		`-/* Silencing I/O errors is bad, but printing spurious tracebacks is`
`323`		`- equally as bad, and potentially more frequent (because of`
`324`		`- shutdown issues). */`
`325`	`322`	`if (res==NULL) {`
`326`		`-#ifndefPy_DEBUG`
`327`		`-if (_Py_GetConfig()->dev_mode) {`
`328`		`-PyErr_WriteUnraisable(self);`
`329`		`- }`
`330`		`-else {`
`331`		`-PyErr_Clear();`
`332`		`- }`
`333`		`-#else`
`334`	`323`	`PyErr_WriteUnraisable(self);`
`335`		`-#endif`
`336`	`324`	`}`
`337`	`325`	`else {`
`338`	`326`	`Py_DECREF(res);`

Comments

(0)