NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

Commit53e6d76

authored

gh-132917: Fix data race detected by tsan (#133508)

Fix data race detected by tsan(https://github.com/python/cpython/actions/runs/14857021107/job/41712717208?pr=133502):young.count can be modified by other threads even while the gcstate islocked.This is the simplest fix to (potentially) unblock beta 1, although thisparticular code path seems like it could just be an atomic swap followed byan atomic add, without having the lock at all.

1 parent296cd12 commit53e6d76Copy full SHA for 53e6d76

File tree

1 file changed

-3

lines changed

Python
- gc_free_threading.c

1 file changed

-3

lines changed

`‎Python/gc_free_threading.c`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2074,10 +2074,9 @@ gc_should_collect_mem_usage(GCState *gcstate)`
`2074`	`2074`	`// clear the young object count so we don't check memory usage again`
`2075`	`2075`	`// on the next call to gc_should_collect().`
`2076`	`2076`	`PyMutex_Lock(&gcstate->mutex);`
	`2077`	`+intyoung_count=_Py_atomic_exchange_int(&gcstate->young.count,0);`
`2077`	`2078`	`_Py_atomic_store_ssize_relaxed(&gcstate->deferred_count,`
`2078`		`-gcstate->deferred_count+`
`2079`		`-gcstate->young.count);`
`2080`		`-_Py_atomic_store_int(&gcstate->young.count,0);`
	`2079`	`+gcstate->deferred_count+young_count);`
`2081`	`2080`	`PyMutex_Unlock(&gcstate->mutex);`
`2082`	`2081`	`return false;`
`2083`	`2082`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit53e6d76

File tree

1 file changed

1 file changed

`‎Python/gc_free_threading.c`

0 commit comments