NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

Commit49f2465

authored

gh-118761: Improve import time ofsubprocess (GH-129427)

* subprocess: lazy import signal and locale to improve module import time

1 parent5ff2fbc commit49f2465Copy full SHA for 49f2465

File tree

2 files changed

+16

-2

lines changed

Lib
- subprocess.py
Misc/NEWS.d/next/Library
- 2025-01-29-10-53-32.gh-issue-118761.i8wjpV.rst

2 files changed

+16

-2

lines changed

`‎Lib/subprocess.py‎`

Lines changed: 14 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,8 @@`
`43`	`43`	`importbuiltins`
`44`	`44`	`importerrno`
`45`	`45`	`importio`
`46`		`-importlocale`
`47`	`46`	`importos`
`48`	`47`	`importtime`
`49`		`-importsignal`
`50`	`48`	`importsys`
`51`	`49`	`importthreading`
`52`	`50`	`importwarnings`
`@@ -144,6 +142,8 @@ def __init__(self, returncode, cmd, output=None, stderr=None):`
`144`	`142`
`145`	`143`	`def__str__(self):`
`146`	`144`	`ifself.returncodeandself.returncode<0:`
	`145`	`+# Lazy import to improve module import time`
	`146`	`+importsignal`
`147`	`147`	`try:`
`148`	`148`	`return"Command '%s' died with %r."% (`
`149`	`149`	`self.cmd,signal.Signals(-self.returncode))`
`@@ -381,6 +381,8 @@ def _text_encoding():`
`381`	`381`	`ifsys.flags.utf8_mode:`
`382`	`382`	`return"utf-8"`
`383`	`383`	`else:`
	`384`	`+# Lazy import to improve module import time`
	`385`	`+importlocale`
`384`	`386`	`returnlocale.getencoding()`
`385`	`387`
`386`	`388`
`@@ -1664,6 +1666,9 @@ def send_signal(self, sig):`
`1664`	`1666`	`# Don't signal a process that we know has already died.`
`1665`	`1667`	`ifself.returncodeisnotNone:`
`1666`	`1668`	`return`
	`1669`	`+`
	`1670`	`+# Lazy import to improve module import time`
	`1671`	`+importsignal`
`1667`	`1672`	`ifsig==signal.SIGTERM:`
`1668`	`1673`	`self.terminate()`
`1669`	`1674`	`elifsig==signal.CTRL_C_EVENT:`
`@@ -1765,6 +1770,9 @@ def _posix_spawn(self, args, executable, env, restore_signals, close_fds,`
`1765`	`1770`	`"""Execute program using os.posix_spawn()."""`
`1766`	`1771`	`kwargs= {}`
`1767`	`1772`	`ifrestore_signals:`
	`1773`	`+# Lazy import to improve module import time`
	`1774`	`+importsignal`
	`1775`	`+`
`1768`	`1776`	`# See _Py_RestoreSignals() in Python/pylifecycle.c`
`1769`	`1777`	`sigset= []`
`1770`	`1778`	`forsignamein ('SIGPIPE','SIGXFZ','SIGXFSZ'):`
`@@ -2214,9 +2222,13 @@ def send_signal(self, sig):`
`2214`	`2222`	`defterminate(self):`
`2215`	`2223`	`"""Terminate the process with SIGTERM`
`2216`	`2224`	`"""`
	`2225`	`+# Lazy import to improve module import time`
	`2226`	`+importsignal`
`2217`	`2227`	`self.send_signal(signal.SIGTERM)`
`2218`	`2228`
`2219`	`2229`	`defkill(self):`
`2220`	`2230`	`"""Kill the process with SIGKILL`
`2221`	`2231`	`"""`
	`2232`	`+# Lazy import to improve module import time`
	`2233`	`+importsignal`
`2222`	`2234`	`self.send_signal(signal.SIGKILL)`

`‎Misc/NEWS.d/next/Library/2025-01-29-10-53-32.gh-issue-118761.i8wjpV.rst‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Improve import time of:mod:`subprocess` by lazy importing ``locale`` and
	`2`	+``signal``. Patch by Taneli Hukkinen.

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit49f2465

File tree

2 files changed

2 files changed

`‎Lib/subprocess.py‎`

`‎Misc/NEWS.d/next/Library/2025-01-29-10-53-32.gh-issue-118761.i8wjpV.rst‎`

0 commit comments