Commit37551c9

authored

gh-107369: optimize textwrap.indent() (#107374)

1 parentf2d07d3 commit37551c9Copy full SHA for 37551c9

File tree

+17

-8

lines changed

+17

-8

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,8 @@ typing`
`150`	`150`	`Optimizations`
`151`	`151`	`=============`
`152`	`152`
`153`		`-`
	`153`	+*:func:`textwrap.indent` is now ~30% faster than before for large input.
	`154`	+ (Contributed by Inada Naoki in:gh:`107369`.)
`154`	`155`
`155`	`156`
`156`	`157`	`Deprecated`

Lines changed: 13 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -476,13 +476,19 @@ def indent(text, prefix, predicate=None):`
`476`	`476`	`consist solely of whitespace characters.`
`477`	`477`	`"""`
`478`	`478`	`ifpredicateisNone:`
`479`		`-defpredicate(line):`
`480`		`-returnline.strip()`
`481`		`-`
`482`		`-defprefixed_lines():`
`483`		`-forlineintext.splitlines(True):`
`484`		`-yield (prefix+lineifpredicate(line)elseline)`
`485`		`-return''.join(prefixed_lines())`
	`479`	`+# str.splitlines(True) doesn't produce empty string.`
	`480`	`+# ''.splitlines(True) => []`
	`481`	`+# 'foo\n'.splitlines(True) => ['foo\n']`
	`482`	+# So we can use just `not s.isspace()` here.
	`483`	`+predicate=lambdas:nots.isspace()`
	`484`	`+`
	`485`	`+prefixed_lines= []`
	`486`	`+forlineintext.splitlines(True):`
	`487`	`+ifpredicate(line):`
	`488`	`+prefixed_lines.append(prefix)`
	`489`	`+prefixed_lines.append(line)`
	`490`	`+`
	`491`	`+return''.join(prefixed_lines)`
`486`	`492`
`487`	`493`
`488`	`494`	`if__name__=="__main__":`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Optimize:func:`textwrap.indent`. It is ~30% faster for large input. Patch
	`2`	`+by Inada Naoki.`

Comments

(0)