Commit34e6f35

authored

gh-92886: [clinic.py] raise exception on invalid input instead of assertion (GH-98051)

Tests should pass with -O (assertions off).Automerge-Triggered-By: GH:iritkatriel

1 parent3de08ce commit34e6f35Copy full SHA for 34e6f35

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ def test_right_only(self):`
`153`	`153`	`deftest_have_left_options_but_required_is_empty(self):`
`154`	`154`	`deffn():`
`155`	`155`	`clinic.permute_optional_groups(['a'], [], [])`
`156`		`-self.assertRaises(AssertionError,fn)`
	`156`	`+self.assertRaises(ValueError,fn)`
`157`	`157`
`158`	`158`
`159`	`159`	`classClinicLinearFormatTest(TestCase):`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -495,7 +495,8 @@ def permute_optional_groups(left, required, right):`
`495`	`495`	`result= []`
`496`	`496`
`497`	`497`	`ifnotrequired:`
`498`		`-assertnotleft`
	`498`	`+ifleft:`
	`499`	`+raiseValueError("required is empty but left is not")`
`499`	`500`
`500`	`501`	`accumulator= []`
`501`	`502`	`counts=set()`

Comments

(0)