Commit2ca0c6c

committed

gh-84808: Handle errors returned by internal_connect()

Python shouldn't assume that errno codes are positive.reported and proposed by Ryan C. Gordon

1 parentd9efa45 commit2ca0c6cCopy full SHA for 2ca0c6c

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3489,7 +3489,7 @@ sock_connect(PySocketSockObject s, PyObject addro)`
`3489`	`3489`	`}`
`3490`	`3490`
`3491`	`3491`	`res=internal_connect(s,SAS2SA(&addrbuf),addrlen,1);`
`3492`		`-if (res<0)`
	`3492`	`+if (res==-1)`
`3493`	`3493`	`returnNULL;`
`3494`	`3494`
`3495`	`3495`	`Py_RETURN_NONE;`
`@@ -3520,7 +3520,7 @@ sock_connect_ex(PySocketSockObject s, PyObject addro)`
`3520`	`3520`	`}`
`3521`	`3521`
`3522`	`3522`	`res=internal_connect(s,SAS2SA(&addrbuf),addrlen,0);`
`3523`		`-if (res<0)`
	`3523`	`+if (res==-1)`
`3524`	`3524`	`returnNULL;`
`3525`	`3525`
`3526`	`3526`	`returnPyLong_FromLong((long)res);`

Comments

(0)