Commit2b563f1

authored

gh-87901: Add encoding to os.popen (GH-92374)

1 parent926854e commit2b563f1Copy full SHA for 2b563f1

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3916,12 +3916,13 @@ written in Python, such as a mail server's external command delivery program.`
`3916`	`3916`	`..availability::Unix.`
`3917`	`3917`
`3918`	`3918`
`3919`		`-..function::popen(cmd, mode='r', buffering=-1)`
	`3919`	`+..function::popen(cmd, mode='r', buffering=-1, encoding=None)`
`3920`	`3920`
`3921`	`3921`	`Open a pipe to or from command cmd.`
`3922`	`3922`	`The return value is an open file object`
`3923`	`3923`	`connected to the pipe, which can be read or written depending on whether mode`
`3924`		- is ``'r'`` (default) or ``'w'``. The buffering argument has the same meaning as
	`3924`	+ is ``'r'`` (default) or ``'w'``.
	`3925`	`+ The buffering and encoding arguments have the same meaning as`
`3925`	`3926`	the corresponding argument to the built-in:func:`open` function. The
`3926`	`3927`	`returned file object reads or writes text strings rather than bytes.`
`3927`	`3928`
`@@ -3944,6 +3945,9 @@ written in Python, such as a mail server's external command delivery program.`
`3944`	`3945`	`documentation for more powerful ways to manage and communicate with`
`3945`	`3946`	`subprocesses.`
`3946`	`3947`
	`3948`	`+ ..versionchanged::3.11`
	`3949`	`+ Added the encoding parameter.`
	`3950`	`+`
`3947`	`3951`
`3948`	`3952`	`..function::posix_spawn(path, argv, env, *, file_actions=None, \`
`3949`	`3953`	`setpgroup=None, resetids=False, setsid=False, setsigmask=(), \`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -974,14 +974,15 @@ def spawnlpe(mode, file, *args):`
`974`	`974`	`# command in a shell can't be supported.`
`975`	`975`	`ifsys.platform!='vxworks':`
`976`	`976`	`# Supply os.popen()`
`977`		`-defpopen(cmd,mode="r",buffering=-1):`
	`977`	`+defpopen(cmd,mode="r",buffering=-1,encoding=None):`
`978`	`978`	`ifnotisinstance(cmd,str):`
`979`	`979`	`raiseTypeError("invalid cmd type (%s, expected string)"%type(cmd))`
`980`	`980`	`ifmodenotin ("r","w"):`
`981`	`981`	`raiseValueError("invalid mode %r"%mode)`
`982`	`982`	`ifbuffering==0orbufferingisNone:`
`983`	`983`	`raiseValueError("popen() does not support unbuffered streams")`
`984`	`984`	`importsubprocess,io`
	`985`	`+encoding=io.text_encoding(encoding)`
`985`	`986`	`ifmode=="r":`
`986`	`987`	`proc=subprocess.Popen(cmd,`
`987`	`988`	`shell=True,text=True,`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Add the encoding parameter to:func:`os.popen`.

Comments

(0)