Commit29a1e89

and

authored

gh-103329: Add regression test for PropertyMock with side effect (GH-103358)

(cherry picked from commit26c6598)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>

1 parent70bc8c9 commit29a1e89Copy full SHA for 29a1e89

File tree

+23

-1

lines changed

+23

-1

lines changed

Lines changed: 22 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1077,7 +1077,7 @@ def test_propertymock(self):`
`1077`	`1077`	`p.stop()`
`1078`	`1078`
`1079`	`1079`
`1080`		`-deftest_propertymock_returnvalue(self):`
	`1080`	`+deftest_propertymock_bare(self):`
`1081`	`1081`	`m=MagicMock()`
`1082`	`1082`	`p=PropertyMock()`
`1083`	`1083`	`type(m).foo=p`
`@@ -1088,6 +1088,27 @@ def test_propertymock_returnvalue(self):`
`1088`	`1088`	`self.assertNotIsInstance(returned,PropertyMock)`
`1089`	`1089`
`1090`	`1090`
	`1091`	`+deftest_propertymock_returnvalue(self):`
	`1092`	`+m=MagicMock()`
	`1093`	`+p=PropertyMock(return_value=42)`
	`1094`	`+ type(m).foo=p`
	`1095`	`+`
	`1096`	`+returned=m.foo`
	`1097`	`+p.assert_called_once_with()`
	`1098`	`+self.assertEqual(returned,42)`
	`1099`	`+self.assertNotIsInstance(returned,PropertyMock)`
	`1100`	`+`
	`1101`	`+`
	`1102`	`+deftest_propertymock_side_effect(self):`
	`1103`	`+m=MagicMock()`
	`1104`	`+p=PropertyMock(side_effect=ValueError)`
	`1105`	`+ type(m).foo=p`
	`1106`	`+`
	`1107`	`+withself.assertRaises(ValueError):`
	`1108`	`+m.foo`
	`1109`	`+p.assert_called_once_with()`
	`1110`	`+`
	`1111`	`+`
`1091`	`1112`	`classTestCallablePredicate(unittest.TestCase):`
`1092`	`1113`
`1093`	`1114`	`deftest_type(self):`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Regression tests for the behaviour of ``unittest.mock.PropertyMock`` were added.

Comments

(0)