Commit1b1db2f

authored

gh-118846: Fix PGO tests in free-threaded build (#118862)

Avoid immortalizing objects in tests that verify garbage collection ofclasses or modules.This fixes test_ordered_dict and test_struct.

1 parent71cc065 commit1b1db2fCopy full SHA for 1b1db2f

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`importweakref`
`11`	`11`	`fromcollections.abcimportMutableMapping`
`12`	`12`	`fromtestimportmapping_tests,support`
`13`		`-fromtest.supportimportimport_helper`
	`13`	`+fromtest.supportimportimport_helper,suppress_immortalization`
`14`	`14`
`15`	`15`
`16`	`16`	`py_coll=import_helper.import_fresh_module('collections',`
`@@ -667,6 +667,7 @@ def test_dict_update(self):`
`667`	`667`	`dict.update(od, [('spam',1)])`
`668`	`668`	`self.assertNotIn('NULL',repr(od))`
`669`	`669`
	`670`	`+@suppress_immortalization()`
`670`	`671`	`deftest_reference_loop(self):`
`671`	`672`	`# Issue 25935`
`672`	`673`	`OrderedDict=self.OrderedDict`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`importweakref`
`10`	`10`
`11`	`11`	`fromtestimportsupport`
`12`		`-fromtest.supportimportimport_helper`
	`12`	`+fromtest.supportimportimport_helper,suppress_immortalization`
`13`	`13`	`fromtest.support.script_helperimportassert_python_ok`
`14`	`14`
`15`	`15`	`ISBIGENDIAN=sys.byteorder=="big"`
`@@ -674,6 +674,7 @@ def __del__(self):`
`674`	`674`	`self.assertIn(b"Exception ignored in:",stderr)`
`675`	`675`	`self.assertIn(b"C.__del__",stderr)`
`676`	`676`
	`677`	`+@suppress_immortalization()`
`677`	`678`	`deftest__struct_reference_cycle_cleaned_up(self):`
`678`	`679`	`# Regression test for python/cpython#94207.`
`679`	`680`

Comments

(0)