Commit175ba36

authored

gh-72902: improve Fraction constructor speed for typical inputs (GH-134320)

This moves abc check for numbers.Rational - down.

1 parente007e62 commit175ba36Copy full SHA for 175ba36

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -238,11 +238,6 @@ def __new__(cls, numerator=0, denominator=None):`
`238`	`238`	`self._denominator=1`
`239`	`239`	`returnself`
`240`	`240`
`241`		`-elifisinstance(numerator,numbers.Rational):`
`242`		`-self._numerator=numerator.numerator`
`243`		`-self._denominator=numerator.denominator`
`244`		`-returnself`
`245`		`-`
`246`	`241`	`elif (isinstance(numerator,float)or`
`247`	`242`	`(notisinstance(numerator,type)and`
`248`	`243`	`hasattr(numerator,'as_integer_ratio'))):`
`@@ -278,6 +273,11 @@ def __new__(cls, numerator=0, denominator=None):`
`278`	`273`	`ifm.group('sign')=='-':`
`279`	`274`	`numerator=-numerator`
`280`	`275`
	`276`	`+elifisinstance(numerator,numbers.Rational):`
	`277`	`+self._numerator=numerator.numerator`
	`278`	`+self._denominator=numerator.denominator`
	`279`	`+returnself`
	`280`	`+`
`281`	`281`	`else:`
`282`	`282`	`raiseTypeError("argument should be a string or a Rational "`
`283`	`283`	`"instance or have the as_integer_ratio() method")`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Improve speed (x1.1-1.8) of the:class:`~fractions.Fraction` constructor for
	`2`	+typical inputs (:class:`float`'s,:class:`~decimal.Decimal`'s or strings).

Comments

(0)