Commit171de05

authored

gh-136523: Fix wave.Wave_write emitting an unraisable when open raises (GH-136529)

1 parent42b251b commit171de05Copy full SHA for 171de05

File tree

+12

-0

lines changed

+12

-0

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`fromtestimportaudiotests`
`3`	`3`	`fromtestimportsupport`
`4`	`4`	`importio`
	`5`	`+importos`
`5`	`6`	`importstruct`
`6`	`7`	`importsys`
`7`	`8`	`importwave`
`@@ -196,6 +197,14 @@ def test_read_wrong_sample_width(self):`
`196`	`197`	`withself.assertRaisesRegex(wave.Error,'bad sample width'):`
`197`	`198`	`wave.open(io.BytesIO(b))`
`198`	`199`
	`200`	`+deftest_open_in_write_raises(self):`
	`201`	`+# gh-136523: Wave_write.__del__ should not throw`
	`202`	`+withsupport.catch_unraisable_exception()ascm:`
	`203`	`+withself.assertRaises(OSError):`
	`204`	`+wave.open(os.curdir,"wb")`
	`205`	`+support.gc_collect()`
	`206`	`+self.assertIsNone(cm.unraisable)`
	`207`	`+`
`199`	`208`
`200`	`209`	`if__name__=='__main__':`
`201`	`210`	`unittest.main()`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -427,6 +427,8 @@ class Wave_write:`
`427`	`427`	`_datawritten -- the size of the audio samples actually written`
`428`	`428`	`"""`
`429`	`429`
	`430`	`+_file=None`
	`431`	`+`
`430`	`432`	`def__init__(self,f):`
`431`	`433`	`self._i_opened_the_file=None`
`432`	`434`	`ifisinstance(f,str):`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix:class:`wave.Wave_write` emitting an unraisable when open raises.

Comments

(0)