Commit16d1085

committed

gh-62948: IOBase finalizer logs close() exceptions

1 parent4b65d56 commit16d1085Copy full SHA for 16d1085

File tree

+15

-24

lines changed

+15

-24

lines changed

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,15 @@ New Modules`
`87`	`87`	`Improved Modules`
`88`	`88`	`================`
`89`	`89`
	`90`	`+io`
	`91`	`+--`
	`92`	`+`
	`93`	+The:class:`io.IOBase` finalizer now logs the ``close()`` method errors with
	`94`	+:data:`sys.excepthook`. Previously, errors were ignored silently by default,
	`95`	+and only logged in:ref:`Python Development Mode<devmode>` or on:ref:`Python
	`96`	+built on debug mode <debug-build>`.
	`97`	+(Contributed by Victor Stinner in:gh:`62948`.)
	`98`	`+`
`90`	`99`	`pathlib`
`91`	`100`	`-------`
`92`	`101`

Lines changed: 2 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,10 +66,6 @@ def byteslike(pos, *kw):`
`66`	`66`	`classEmptyStruct(ctypes.Structure):`
`67`	`67`	`pass`
`68`	`68`
`69`		`-# Does io.IOBase finalizer log the exception if the close() method fails?`
`70`		`-# The exception is ignored silently by default in release build.`
`71`		`-IOBASE_EMITS_UNRAISABLE= (support.Py_DEBUGorsys.flags.dev_mode)`
`72`		`-`
`73`	`69`
`74`	`70`	`def_default_chunk_size():`
`75`	`71`	`"""Get the default TextIOWrapper chunk size"""`
`@@ -1218,10 +1214,7 @@ def test_error_through_destructor(self):`
`1218`	`1214`	`withself.assertRaises(AttributeError):`
`1219`	`1215`	`self.tp(rawio).xyzzy`
`1220`	`1216`
`1221`		`-ifnotIOBASE_EMITS_UNRAISABLE:`
`1222`		`-self.assertIsNone(cm.unraisable)`
`1223`		`-elifcm.unraisableisnotNone:`
`1224`		`-self.assertEqual(cm.unraisable.exc_type,OSError)`
	`1217`	`+self.assertEqual(cm.unraisable.exc_type,OSError)`
`1225`	`1218`
`1226`	`1219`	`deftest_repr(self):`
`1227`	`1220`	`raw=self.MockRawIO()`
`@@ -3022,10 +3015,7 @@ def test_error_through_destructor(self):`
`3022`	`3015`	`withself.assertRaises(AttributeError):`
`3023`	`3016`	`self.TextIOWrapper(rawio,encoding="utf-8").xyzzy`
`3024`	`3017`
`3025`		`-ifnotIOBASE_EMITS_UNRAISABLE:`
`3026`		`-self.assertIsNone(cm.unraisable)`
`3027`		`-elifcm.unraisableisnotNone:`
`3028`		`-self.assertEqual(cm.unraisable.exc_type,OSError)`
	`3018`	`+self.assertEqual(cm.unraisable.exc_type,OSError)`
`3029`	`3019`
`3030`	`3020`	`# Systematic tests of the text I/O API`
`3031`	`3021`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,4 @@`
	`1`	+The:class:`io.IOBase` finalizer now logs the ``close()`` method errors with
	`2`	+:data:`sys.excepthook`. Previously, errors were ignored silently by default,
	`3`	+and only logged in:ref:`Python Development Mode<devmode>` or on
	`4`	+:ref:`Python built on debug mode<debug-build>`. Patch by Victor Stinner.

Lines changed: 0 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -319,20 +319,8 @@ iobase_finalize(PyObject *self)`
`319`	`319`	`if (PyObject_SetAttr(self,&_Py_ID(_finalizing),Py_True))`
`320`	`320`	`PyErr_Clear();`
`321`	`321`	`res=PyObject_CallMethodNoArgs((PyObject*)self,&_Py_ID(close));`
`322`		`-/* Silencing I/O errors is bad, but printing spurious tracebacks is`
`323`		`- equally as bad, and potentially more frequent (because of`
`324`		`- shutdown issues). */`
`325`	`322`	`if (res==NULL) {`
`326`		`-#ifndefPy_DEBUG`
`327`		`-if (_Py_GetConfig()->dev_mode) {`
`328`		`-PyErr_WriteUnraisable(self);`
`329`		`- }`
`330`		`-else {`
`331`		`-PyErr_Clear();`
`332`		`- }`
`333`		`-#else`
`334`	`323`	`PyErr_WriteUnraisable(self);`
`335`		`-#endif`
`336`	`324`	`}`
`337`	`325`	`else {`
`338`	`326`	`Py_DECREF(res);`

Comments

(0)