Commit127bd9b

and

authored

bpo-34042: Fix dict.copy() to maintain correct total refcount (GH-8119)

(cherry picked from commit0b75228)Co-authored-by: Yury Selivanov <yury@magic.io>

1 parent4bd5fce commit127bd9bCopy full SHA for 127bd9b

File tree

-0

lines changed

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Fix dict.copy() to maintain correct total refcount (as reported by`
	`2`	`+sys.gettotalrefcount()).`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -656,6 +656,13 @@ clone_combined_dict(PyDictObject *orig)`
`656`	`656`	`/* Maintain tracking. */`
`657`	`657`	`_PyObject_GC_TRACK(new);`
`658`	`658`	`}`
	`659`	`+`
	`660`	`+/* Since we copied the keys table we now have an extra reference`
	`661`	`+ in the system. Manually call _Py_INC_REFTOTAL to signal that`
	`662`	`+ we have it now; calling DK_INCREF would be an error as`
	`663`	`+ keys->dk_refcnt is already set to 1 (after memcpy). */`
	`664`	`+_Py_INC_REFTOTAL;`
	`665`	`+`
`659`	`666`	`return (PyObject*)new;`
`660`	`667`	`}`
`661`	`668`

Comments

(0)