Commit06eaf40

and

authored

gh-71253: Match _io exception in _pyio (gh-133985)

Test was only testing _io, expanded to cover _pyio.Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

1 parent84d5f8d commit06eaf40Copy full SHA for 06eaf40

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1563,7 +1563,8 @@ def __init__(self, file, mode='r', closefd=True, opener=None):`
`1563`	`1563`	`ifnotisinstance(fd,int):`
`1564`	`1564`	`raiseTypeError('expected integer from opener')`
`1565`	`1565`	`iffd<0:`
`1566`		`-raiseOSError('Negative file descriptor')`
	`1566`	`+# bpo-27066: Raise a ValueError for bad value.`
	`1567`	`+raiseValueError(f'opener returned{fd}')`
`1567`	`1568`	`owned_fd=fd`
`1568`	`1569`	`ifnotnoinherit_flag:`
`1569`	`1570`	`os.set_inheritable(fd,False)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -918,15 +918,15 @@ def test_bad_opener_negative_1(self):`
`918`	`918`	`defbadopener(fname,flags):`
`919`	`919`	`return-1`
`920`	`920`	`withself.assertRaises(ValueError)ascm:`
`921`		`-open('non-existent','r',opener=badopener)`
	`921`	`+self.open('non-existent','r',opener=badopener)`
`922`	`922`	`self.assertEqual(str(cm.exception),'opener returned -1')`
`923`	`923`
`924`	`924`	`deftest_bad_opener_other_negative(self):`
`925`	`925`	`# Issue #27066.`
`926`	`926`	`defbadopener(fname,flags):`
`927`	`927`	`return-2`
`928`	`928`	`withself.assertRaises(ValueError)ascm:`
`929`		`-open('non-existent','r',opener=badopener)`
	`929`	`+self.open('non-existent','r',opener=badopener)`
`930`	`930`	`self.assertEqual(str(cm.exception),'opener returned -2')`
`931`	`931`
`932`	`932`	`deftest_opener_invalid_fd(self):`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Raise:exc:`ValueError` in:func:`open` if opener returns a negative
	`2`	+file-descriptor in the Python implementation of:mod:`io` to match the
	`3`	`+C implementation.`

Comments

(0)