Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Accept GitHub issues numbered only 32426 or above#519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 6 commits intopython:mainfrommenkotoglou:main
Dec 29, 2023

Conversation

menkotoglou
Copy link
Contributor

Fixes#504.

Iterates through the template file to find the gh-issue line and checks number if it's in the accepted issue number range.

This is how an unsuccessful attempt looks like:

❯ /bin/python3 /path/core-workflow/blurb/blurb.pyError: The gh-issue number should be 32426 or above.[Hitreturn to retry (or Ctrl-C to abort)>

svaloumas reacted with rocket emoji
@ghost
Copy link

ghost commentedDec 17, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please could you add some tests?

Hopefully we can get#520 merged soon, then we can add unit tests.

In the meantime, tests are done by adding valid blurb files in thepass dir and invalid ones in thefail dir athttps://github.com/python/core-workflow/tree/main/blurb/tests, and then runningblurb test.

ezio-melotti and menkotoglou reacted with thumbs up emoji
@menkotoglou
Copy link
ContributorAuthor

Seems like thenot_number case is already covered in the code. That's validated in the pre-existinginvalid-gh-number.rst test case.

Also, the tests wouldn't pass if we didn't raise an exception at theclass Blurbs level. Decided to move to the class definition level as I'm aligned with this approach.

Finally, retrospectively fixed some old tests that indeed were using smaller GH issue numbers.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! It's nice when adding tests reveals a problem in the original implementation :)

Looks good, here's a wording suggestion.

@menkotoglou
Copy link
ContributorAuthor

Thanks a lot for the review@hugovk. Suggestion commited!

hugovk reacted with thumbs up emoji

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

menkotoglou reacted with hooray emoji
Copy link
Member

@pradyunsgpradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple of non-blocking suggestions, with one of them being a nitpick that you're welcome to ignore if it's too much effort and a request to name amagic number.

@menkotoglou
Copy link
ContributorAuthor

Thanks a lot for the review@pradyunsg. Feedback addressed already!

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
@menkotoglou
Copy link
ContributorAuthor

Hey@pradyunsg,@hugovk, you think we're OK to merge this?

@hugovk
Copy link
Member

Yes, let's merge. Thank you for your contribution!

menkotoglou reacted with hooray emoji

@hugovkhugovk merged commitc9c3e4a intopython:mainDec 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@pradyunsgpradyunsgpradyunsg left review comments

@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blurb: validate GitHub issue number
4 participants
@menkotoglou@hugovk@pradyunsg@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp