Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork60
Relax click dependency.#302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Allow to install cherry_picker with the modern click version
willingc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks@asvetlov.
Thanks! Do you need a release cut? |
It would be nice! |
Can you increase/update the version info, and the changelog? After that, create a GitHub tag of the release branch, and it will be automatically released to PyPI. There's a brief write-up here:https://github.com/python/core-workflow/tree/master/cherry_picker#publishing-to-pypi |
Will try |
v1.2.2 is now on PyPI |
| @@ -381,11 +381,11 @@ def check_repo(self): | |||
| help=("Path to config file, .cherry_picker.toml " | |||
| "from project root by default"), | |||
| default=None) | |||
| @click.argument('commit_sha1', 'The commit sha1 to be cherry-picked', nargs=1, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why remove the explanation? How is this related to the click dependency update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh, they changed api..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Explicitly forbade meaningless argument actually. The help was never displayed IIRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, nevermind. I've already figured out that it fails with this arg under newer Click:https://travis-ci.org/python/core-workflow/jobs/491106736#L270
Allow to install cherry_picker with the modern click version