Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork60
Implement storing runtime state in repo level Git config#295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Implement storing runtime state in repo level Git config#295
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8b05f5b
todf45585
Comparewebknjaz commentedNov 27, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@Mariatta, I'm currently waiting for your approval wrt architectural changes. After that I'll proceed with adjusting/adding tests. P.S.@abadger suggested that I could add a CLI command for |
Sorry for the delay. Will take a look in the weekend. |
Cool, thanks :) |
Hey@Mariatta, any 🤔💭 on this so far? |
Hi@Mariatta, any comments? |
So sorry, I think I'm not able to effectively review this PR. |
I'll ask@asvetlov to take a look as well, then, to have more eyes on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The idea looks interesting.
Would you add tests for it?
At least we have several ones intest.py
already.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the review, Andrew! I just wanted to wait for architectural approval before investing some time into tests. Now I can proceed :) |
Great, thanks@Mariatta! |
f4f8d67
toa207fb9
Compare4b63d05
todda278d
Comparedda278d
to1a5d76f
CompareUpdate: with the recent commits I've hit 83% test coverage. |
Uh oh!
There was an error while loading.Please reload this page.
Co-Authored-By: webknjaz <wk.cvs.github@sydorenko.org.ua>
Thanks. I'll ping them. I think Andrew is away for a couple of days, though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM now
Sure, on it |
done! |
Thanks! Will release soon! |
Uh oh!
There was an error while loading.Please reload this page.
Ref#277